search

sp-tarkov / server

University of Illinois/NCSA Open Source License
2 stars 3 forks source link

ragfairConfig.dynamic.unreasonableModPrices not working #494

Closed refringe closed 2 hours ago

refringe commented 2 hours ago

General information:

Project issue is for:
Server

Expected result:
In ragfairConfig.dynamic.unreasonableModPrices for "5448fe124bdc2da5018b4567" (Weapon Mods) configs handbookPriceOverMultiplier & newPriceHandbookMultiplier don't seem to affect the flea price.

When I set these multipliers to one, I expect attachments like the SVDS muzzle brake https://db.sp-tarkov.com/search/5c471bfc2e221602b21d4e17 go from 40k to around 600 roubles.

Actual result:
Attachment flea prices don't seem to change and the SVDS muzzle brake (just one example I like to go to) remains at 40k roubles.

When I debugged adjustUnreasonableModFleaPrices() https://dev.sp-tarkov.com/SPT-AKI/Server/src/branch/master/project/src/services/ProfileFixerService.ts I saw that the flea prices were being overriden to the correct value but they don't seem to appear in the flea market.

I have not changed any config or used any mods except for the described ragfairConfig change above.

How to reproduce:

  1. Update ragfairConfig.dynamic.unreasonableModPrices["5448fe124bdc2da5018b4567"] setting both multipliers to 1 (config attached)
  2. Launch game and check price of attachments, using SVDS muzzle brake as a good example

Attachments

Originally written by Platinum

refringe commented 2 hours ago

Hopefully fixed: https://dev.sp-tarkov.com/SPT-AKI/Server/commit/791ebd46934dca9a17fddea5e0e85caa850ecf09

Originally written by chomp

refringe commented 2 hours ago

Hopefully fixed: https://dev.sp-tarkov.com/SPT-AKI/Server/commit/791ebd46934dca9a17fddea5e0e85caa850ecf09

Unfortunately I don't think it's fixed. I tried testing the default 6x mult and looking at the SVDS* attachments and they're still much more expensive than 6x the handbook price.

When I set the mult to 1x for 5448fe124bdc2da5018b4567 (Weapon Mods), it still shows everything at their normal inflated flea prices, like with the 6x mult.

Attachments

Originally written by Platinum

refringe commented 2 hours ago

Second fix: https://dev.sp-tarkov.com/SPT-AKI/Server/commit/d3f66a85a0d15337bc5c535e1335c588ca4f75d1

Originally written by chomp

refringe commented 2 hours ago

Looks fixed with the second commit. Prices looks much better when random small attachments aren't super inflated.

Originally written by Platinum