[3.8.0] Peacekeeper gives FIR Dollars if you only have a stack of FIR dollars in your stash when selling items to him

[refringe]

General information:

Project issue is for:
Server

Expected result:
Receiving non-FIR dollars when selling items to Peacekeeper

Actual result:
My FIR dollar stack increases when I sell items to Peacekeeper

How to reproduce:

1. Only have FIR Dollars in your stash
2. Sell items to Peacekeeper

---

Attachments

• server-2024-02-08.log (1169 KiB)
• LogOutput.log (11 KiB)
• 2024.02.08_3-46-24_0.14.0.1.28476 traces.log (49 KiB)
• EscapeFromTarkov 2024-02-08 06-48-03.mp4 (25979 KiB)

---

Originally written by Hicchy

[refringe]

might be due to us finding first suitable stack and not checking their FiR status, we should be moving on if its FiR

---

Originally written by CWX

[refringe]

I haven't played Live on either of the last two wipes, but this is exactly how Live behaved prior to that, and it behaved like that with all traders, and both Dollars and Roubles (nobody pays you in Euros).

2 wipes ago I routinely used this behavior to convert my non-FIR roubles to FIR--Vendor behavior used to be (and might still be) to fill partial money stacks before creating new ones, even if existing partial stacks were FIR. When filling partial FIR stacks, FIR status was preserved.

It should be pretty easy to test this on live:

• Make sure you have only 1 partial non-FIR stack of roubles;
• Put your 1 partial non-FIR Rouble stack inside a container, or on your PMC;
• Split an FIR stack of Roubles into multiple smaller ones, which each keep , and put them bare at the top of your stash;
• Sell > 500k Roubles worth of stuff to anyone but Peacekeeper;
• Vendor might fill the partial non-FIR stack first, and if BSG hasn't changed anything, the rest should go into any partial FIR Rouble stacks until they're all full, at which point any new stack created will be non-FIR.

---

Originally written by Brin

[refringe]

Tested and reproduced on live, selling to Peacekeeper with only a FIR stack of USD adds to that stack

---

Attachments

• FIRStacks.mp4 (5760 KiB)

---

Originally written by DrakiaXYZ