sp-tarkov / server

University of Illinois/NCSA Open Source License
24 stars 5 forks source link

Replace remaining uses of `additem()` with `addItemToStash()` #630

Closed refringe closed 6 days ago

refringe commented 6 days ago

handleScavCase() handleRecipe() x2 removeResourceFromArea()

getBTC()

openRandomLootContainer()

giveProfileMoney()

Testing: Scavcase rewards:


Originally written by chomp

refringe commented 6 days ago

giveProfileMoney(): https://dev.sp-tarkov.com/SPT-AKI/Server/commit/4bca0b77475637a8efc871ecf54dd1b09cb4fc65


Originally written by chomp

refringe commented 6 days ago

getBTC(): https://dev.sp-tarkov.com/SPT-AKI/Server/commit/80b549a2d50a2faa4081aaf134e28b1aed95fb2d


Originally written by chomp

refringe commented 6 days ago

openRandomLootContainer(): https://dev.sp-tarkov.com/SPT-AKI/Server/commit/d112d0fa6e128851302262e342815182c6f79df6


Originally written by chomp

refringe commented 6 days ago

removeResourceFromArea(): https://dev.sp-tarkov.com/SPT-AKI/Server/commit/910b5e946c72297de3d5ee43a71af44eb93292c4


Originally written by chomp

refringe commented 6 days ago

handleScavCase(): https://dev.sp-tarkov.com/SPT-AKI/Server/commit/c68c9a72fb66ec78bfa3f2f8d30356e66b9889aa


Originally written by chomp

refringe commented 6 days ago

handleRecipe(): https://dev.sp-tarkov.com/SPT-AKI/Server/commit/32eb8ae35cc54b8f2387e123464c5c60d744908b


Originally written by chomp

refringe commented 6 days ago

Can confirm the below works as intended, can we cross this section out?

Sealed weapon case:


Originally written by naterade

refringe commented 6 days ago

Hideout crafting: ammo craft might still be bugged, only got 50 instead of 150. Will run again armor, weapon, multi food items and meds crafts all worked as intended


Originally written by naterade

refringe commented 6 days ago

Can confirm certain ammo crafting is bugged. Gunpowder Kite > 9x18 PMM should give 140 but only gives one stack of 50.


Originally written by Aburiu

refringe commented 6 days ago

https://dev.sp-tarkov.com/SPT-AKI/Server/commit/ca02aa6a505878aa4d3db1677377990d59a589ef fixed this issue.


Originally written by Kaeno

refringe commented 6 days ago

Yep, ammo crafts work correctly now.

Scav case rewards: Weapon, Armor, Money all seem to work fine.


Originally written by Aburiu

refringe commented 6 days ago

Concur, its fixed, vote to close issue


Originally written by naterade