search

sp00m / gulp-watch-sass

Watches for SASS files modifications, taking @import-ing SASS files into account.
MIT License
6 stars 2 forks source link

[1.1.4] Allow setting explicit base path for watched files #4

Closed aapokiiso closed 7 years ago

aapokiiso commented 7 years ago

We had a case where the source glob could be different depending on build config (for example src/frontend/*/*/css/*.scss vs. src/frontend/namespace/themename/css/*.scss), but the destination directory is always the same skin. Without the base option those different globs would result in files being written in different directories, but setting the base option in gulp.src as src fixed this. However it wasn't yet possible here in gulp-watch-sass.

Setting the base path is possible in gulp-watch, so I thought it would make sense to also allow it here. I'm not sure about the usefulness of the other options in gulp-watch, but @sp00m can probably say if the whole options object could be passed into gulp-watch.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 92.632% when pulling eca6489380c11a2f9c7643b4b2faa74daf5dc7c8 on aapokiiso:allow-base-option into b76eb820d9be78ac66df747dbbc8670ac00b1555 on sp00m:master.

sp00m commented 7 years ago

Thank you for this, I'll have a look and keep you informed soon!

sp00m commented 7 years ago

Landed, thanks! I tweaked it a bit so that the whole options object is passed directly to gulp-watch as you proposed ;)