sp614x / optifine

1.79k stars 419 forks source link

Optifine versions (since new MC launcher) overwrite existing/older Optifine profiles #1113

Open LapisDemon opened 6 years ago

LapisDemon commented 6 years ago

Ever since the new Minecraft Launcher got released (around February 2017), I noticed that Optifine does not create a completely new profile like it did before anymore, but installs itself into a previous, already-existing Optifine profile - at least between 1.11/1.12-versions, I did not conduct tests with freshly installed older OF versions.

I got several older Optifine profiles, so let's say I got an "1.11.2 Optifine" profile and install Optifine 1.12.2, then the profile's name will still be of course "1.11.2 Optifine", but the selected OF version will be the newly installed 1.12.2: image

Which means I have to manually deselect the new OF version, reselect the 1.11.2 OF version, and create a new 1.12.2-OF-version manually.

I accidentally recorded this behaviour whilst recording a general installation tutorial, unlisted video of that behaviour can be seen here: https://youtu.be/GsD65r6fqrU

With the previous Minecraft launcher, Optifine always created a very own/new profile, but at least in my case it does not anymore, but "hijacks" an older OF profile instead.

I notified about this in 2 emails image but as it also occurred now with the latest 1.12.2 C7-version, I thought I'd report it now finally via the OF issue tracker here.

Interestingly, 1.12.2 C7 "took over" my old 1.11.2-OF-profile again, but not the previously installed 1.12 C4 or C2 profile, although they are more recent versions than the 1.11.2-OF-profile.

Sorry if this was already reported or is considered WaI, I searched around and couldn't find anything about it.

sp614x commented 6 years ago

You are probably renaming the OptiFine profile to something else (1.11.2 OptiFine). The old launcher is probably renaming the profile correctly (identity and visible name) while the new launcher probably only changes the visible name. So for the installer this is still the original profile.

LapisDemon commented 6 years ago

Not sure if I understand you or you me, I may have phrased it confusing (sorry, I'm not a native English speaker :))

The new launcher does not change the visible name, or else I would have two 1.11.2-OF profiles, one where my old 1.11.2-OF is selected, and one with a new 1.12.2 OF. But I only got one single 1.11.2 OF profile.

What OF 1.12.x in the new launcher does is to "kick out" the selected 1.11.2 OF version in the 1.11.2 profile and selects itself as the one to be started with that 1.11.2 OF profile. But I want to have several different OF versions parallel/next to each other, which I have to set manually now, in comparison to the old launcher.

I'll try again to explain, this time a bit more detailed and hopefully better understandable: Indeed, I renamed the 1.11.2 Optifine profile after I installed OF for 1.11.2 back then, but I always renamed all my OF profiles into "MC version + Optifine", also the 1.12(.0 and .2) Optifine profile; what I find puzzling is the fact that OF does not seem to create a completely new/own Minecraft profile anymore, but choses an older already-existing OF profile.

There are people like myself who hop from newer to older MC version and vice versa, which means if a new OF version automatically selects one of my older profiles and I wouldn't notice it, I would start e.g. the wrong version OF 1.12.2 instead of OF 1.11.2.

From how I recall it with the old launcher, Optifine always created a completely new profile, additionally to already-existing OF profiles if there were any, but with the new launcher it selects my old already-existing 1.11.2 OF profile and does not create an additional, completely new one.

So in the old launcher you could have had a OF 1.11.2 C1 profile, and when you installed C2, it would additionally create a C2 profile, and so on and so forth. OF does not delete older OF versions, I hope I did not phrase it that misunderstandably, but it choses a pre-existing older OF profile which I want to remain an old OF profile, as I still need older MC versions for various reasons.

I also renamed the profiles back then in the old Launcher, never had that issue like with the new launcher.

In the old Launcher the new OF profile called itself simply "Optifine" as you can see here: image and was the first selected profile upon starting the (old) launcher, which is also not the case anymore with the new launcher.

Having all of that said, I can live with it, it's just a minor annoyance and I have to remember to set everything back and add another OF profile after installing a new OF version, there are plenty of bugs and awesome additions which need your attention way more than this comparably minor annoyance ;)

I just wanted to let you know, as I may not be the only one who may run into this and ends up being a bit confused, even more so longtime MC players and longtime Optifine users.

So you can close this issue here, I don't mind, I'll just have to adapt to the new circumstances, I was just worried about others who may have problems with it as well.

Thank you for your hard work, have a good New Year! Meri