sp614x / optifine

1.81k stars 418 forks source link

ability to turn off the ugly floor plane without turning off sky #1200

Open xemnes opened 6 years ago

xemnes commented 6 years ago

is it possible to have an option to remove this ugly plane without having to turn off sky? https://cdn.discordapp.com/attachments/286649185468678144/407709504780894209/unknown.png

i dont recall 1.7.10 having this if you turn off sky, it disappears https://cdn.discordapp.com/attachments/286649185468678144/407709873191649291/unknown.png

but then the skys gradient is removed would be nice to be able to have sky turned on, without the plane.

i believe this was added in 1.9+, i am using 1.10.2. i dont know if it follows in later releases as ive not used them

sp614x commented 6 years ago

This is the horizon (player above Y=64) or the void (player below Y=64). Should it be controlled by shaders (shaders.properties) or by the resource packs (Custom Sky)?

xemnes commented 6 years ago

should be controlled by custom sky really. its more universal as it would support both with and without shaders

Lindolas commented 6 years ago

I hope this gets fixed somhow because it's pretty annoying to see the void cutting off the skybox.

This started with OptiFine 1.12.2_HD_U_C7 version. And when I checked the changelog I saw this: "- fixed missing void when VBO enabled and Y > 64"

I'm pretty sure this is the reason why the void is now showing because previously it was only showing with VBO turned off.

Wonkatoad commented 6 years ago

I've noticed this as well. It's particularly noticeable during sunrise and sunset, even when not using a custom sky. The orange glow that appears around the sun and lights up the sky makes it much more apparent. I also noticed that the size of the plane, or distance of the horizon changes according to your render distance. Also, depending on which direction your facing, the corners of the square will be cut off, creating a very unnatural look, similar to how fast fog changes depending on which direction you look. Having the option to disable this artificial horizon would be very much appreciated, as it cuts off custom skyboxes, such as those that are meant to create the effect of being above the clouds. Thank you!

sp614x commented 6 years ago

When void is disabled the custom sky is visible, but there are problems with shaders:

image

image

xemnes commented 6 years ago

is that unmodified? as in, not made any changes to optifine? because i do notice it when shaders are set to internal, i dont set it to none because it reloads the resource pack and with conquest reforged, it takes forever.

sp614x commented 6 years ago

This is with modified OF (disabled void). The internal shaders are OK when the void is not rendered:

image

sp614x commented 6 years ago

Sildur's Vibrant 1.17 gets this problem on sunset when the void is disabled:

image

xemnes commented 6 years ago

thats the thing though, the fact the void is rendered at all is the issue. in 1.7.10, it wasnt visible until you hit level 0.

sp614x commented 5 years ago

In 1.14 the VBO option is always ON (if supported) and the corresponding bug is marked as "Works As Intended" so apparently in 1.14+ the default behaviour is not to show the void above Y=64. https://bugs.mojang.com/browse/MC-45044 https://bugs.mojang.com/browse/MC-68758

sp614x commented 5 years ago

OptiFine 1.14.2_HD_U_F1_pre8

sp614x commented 5 years ago

Shaders need the void rendering in order to properly render sky below the horizon: #2522

sp614x commented 5 years ago

The solution seems to be

This would fix the custom sky conflict with the void.

xemnes commented 5 years ago

not sure how much it matters to me anymore, im still running 1.10.2 and was the latest version as of the time i submitted this, and im probably not going to be getting a backport considering the latest version is 1.14.

sp614x commented 5 years ago

This can probably be backported down to 1.8 without problems.

xemnes commented 5 years ago

that would be very helpful if its easily done.

sp614x commented 5 years ago

OptiFine 1.14.3_HD_U_F1_pre16

The custom sky bugfix that is compatible with shaders will be added later.