search

sp614x / optifine

1.8k stars 418 forks source link

Custom Item Model bugged 1.13.1 #1875

Closed Aaron2550 closed 5 years ago

Aaron2550 commented 5 years ago

The weapons are from https://goo.gl/Qd5Dzo, I fixed one of the many models myself but changing scale and rotation is very tedious. Did something change or this an OptiFine issue (which i'm pretty sure it is) ? There's probably something obvious im missing... chrome_2018-10-07_17-24-22 javaw_2018-10-07_17-23-31

joshi77 commented 5 years ago

is that a mod or? armor stands? or vanilla with idk what?

Aaron2550 commented 5 years ago

is that a mod or? armor stands? or vanilla with idk what?

resource pack, sorry the link doesnt seem to work, its on OptiFine pre4 1.13.1

https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/resource-packs/2880628-extra-3d-weapons-if-you-get-an-anvil-and-rename-a

Stevecurious commented 5 years ago

1787 #1824

Seems to be still up. OptiFine somehow currently does not recognize the different settings for scale, rotation and translation when used as CIT.

sp614x commented 5 years ago

Are the CIT models working properly in 1.12.2?

Aaron2550 commented 5 years ago

Yep, its a 1.12.2 pack, i even tested it right after i saw it was bugged in 1.13.1 because i couldnt believe it was OptiFine's "fault" (I remembered to have read "Fixed Custom Items" in the changelog, but it apparently has nothing to do with CIT's ), its perfectly normal in 1.12.2

Aaron2550 commented 5 years ago

OH! what might be interesting is that ive managed to port one specific model from that respack to 1.13.1, it works fine, scale and rotation work perfectly, although i cant remember how i did it, if you guys need that model as it could help i can upload it.

sp614x commented 5 years ago

Item rendering and model loading are significantly different between 1.12 and 1.13 so it is quite possible that OptiFine 1.13 doesn't handle or handles incorrectly the model transforms.

sp614x commented 5 years ago

Are the 1.13 CIT models not reacting to scale/transforms at all (always using the original model transforms) or are the transforms just applied differently? It may also be that the original and replacement model transforms are applied on top of each other.

Aaron2550 commented 5 years ago

i dont understand any of that stuff but ill upload the ported model incase it is any help. i renamed it from .json to .txt because github doesnt support .json. the model is from the same respack trident_in_hand.txt

Stevecurious commented 5 years ago

Let me explain that a bit more: the custom items don't react to scaling, rotating or translating at all. Several items are displayed differently when set on head, like the end rod making an unicorn horn. Thus I can report that for example my models based on a gold nugget are just displayed where the center of the normal gold nugget would be when set on hat. (They are normally displayed at the back of the head right above it like in a 2D grid)

2018-10-14_12 05 43 2018-10-14_12 02 51 2018-10-14_12 03 23

The image with the golden crown shows that translation isn't working, is it should be moved several pixels towards the middle of the hat, the other one indicating all three settings not working (should be rotated, scaled down and translated properly). These are no problems with the models itself, if I define them as the normal model for a gold nugget (or every other item), the settings work. So it is an issue with how Custom Item Models recognize these settings. Hope that helps a bit :)

Aaron2550 commented 5 years ago

Thanks! I kinda understand it now, so basically only scale, rotation and position are bugged.

sp614x commented 5 years ago

Fixed, coming in pre6.