sp614x / optifine

1.81k stars 418 forks source link

[Request] Allow LocName tag in CIT models #2007

Open OktayYeniTR opened 6 years ago

OktayYeniTR commented 6 years ago

https://minecraft.gamepedia.com/Player.dat_format#Display_Properties

OktayYeniTR commented 6 years ago

and can u update turkish lang?

Regnander commented 6 years ago

(As a side note, "LocName" was changed to "translate" in 1.13):

Instead of LocName:"gui.toTitle", use Name:"{\"translate\":\"gui.toTitle\"}".

In cit_single.properties, the nbt.display.Name attribute doesn't seem to have support for localized names, since I downloaded a resource pack with CITs and tried to add various values to this attribute in order to make it work with item addresses (_item.minecraft.tropical_fishbucket in this case), but nothing seems to work.

Since the attribute already has support for prefixes such as "regex:" and "pattern:", I suggest to add "translate:" as a new prefix. For example, if the name of "Totem of Undying" is to be used for a CIT, you would have to add nbt.display.Name=translate:"item.minecraft.totem_of_undying" to the properties file.