sp614x / optifine

1.78k stars 419 forks source link

Optifine won't load in Magic Launcher 1.3.4 #2289

Open TNTUP opened 5 years ago

TNTUP commented 5 years ago

Heya! If anyone still uses Magic Launcher for Optifine 1.13.2 like me you may be aware it does not longer works with ML. I've attempted a workaround, by comparing 1.12.2's json and 1.13.2 and the way it works, the "minecraftArguments" is no longer used in 1.13+. Instead it uses "arguments: game: blabla" to work.

I replaced arguments into minecraftArguments and removed every ", " but keeping json formatting and when I tested it on Magic Launcher, it worked! I got Optifine 1.13.2/1.14.4/1.15.2/1.16.1/1.16.2 to work with Magic Launcher even I can make snapshots to work aswell but my main concern is making future versions to work with Magic Launcher, despite being unsupported maybe?

Using vanilla 1.13.2 (and optifine) without my workarond throws this error https://pastebin.com/Rc2mxnDQ I noticed there's issues about this related to TLauncher which I'm not using it and what I've seen it misses ASM classes I don't know?

What I'm asking, if Sp418x can add 1.13+ compatibility for Optifine (including vanilla snapshots, future versions of Forge, or other launchwrappers like labymod? ect) but asking support for Forge or anything is quite offtopic. So I can avoid using my own workaround everytime I need to edit the version's json file manually to make it work (eg snapshots). I keep the original version then copy-paste it and I add ".ml" at the end of the folder/file names and in the json then rearrange the "arguments" to make it work :)

Also, my english is very bad so sorry if there's any bad grammar :X

PS: I've made this issue because Sp maintains (or its inactive/discontinued?) MagicLauncher and posts on minecraftforums.net seems to be ignored so I try seeking support here as Optifine development is active.

PSS: I know I can use Mojang's launcher, but the ** issue is, token based auth and sometimes it happens that they expire and forces me to re-enter the password and I never tried how many accounts Mojang Launcher can hold. I was lucky when Sp increased the limit to 100. That would be anotherr suggestion if Sp can add a config or increasing to 200 or whatever for offline purposes.

TNTUP commented 5 years ago

Can't even run 1.14.2 pre6 or 1.14 ones. Is MagicLauncher still supported by you @sp614x ? And if thats possible to increase the account limit to 200? Or allowing us to define what limit of accounts. I really love this launcher and Optifine

sp614x commented 4 years ago

The MagicLauncher is not actively developed anymore. It may be updated to support 1.13+, but there is no guarantee when this would be.

TNTUP commented 4 years ago

Oh noes 😭 😭 😭 😭

Actively using it since Minecraft Beta and this is THE only launcher I USE because I don't have to re-enter my email or password which Mojang Launcher does, and forces users to do that. Its a pain in the ass when you own a lot of accounts and thats why I'm using MagicLauncher... It remembers email/password which others does not... I refuse to switch launchers because of this... I hope you can make support for 1.13+ cuz im selflocking to 1.12.2 and if possible to increase accout limit to 200, and save them in a file like "accounts.json" and encrypt passwords with a strong algorithm...

If I had money I'd donate again like I did with Optifine, not sure if you still accept Paypal (atm nope from the website)

TNTUP commented 4 years ago

Please don't let Magic Launcher die, I'm way too attached to it and no such launcher remembers email/password (encrypted way) (ik its weird, its a pain in the ass using mojang's launcher as soon the token expires, forces the user to re-enter the email/pwd...)

Let me know when you feel updating Magic Launcher to support 1.13.x, 1.14.x and so on and maybe increasing to 200 if thats possible (else save them in a json file)...

Welp, thats sad its not developed anymore 😭

TNTUP commented 4 years ago

Sorry if im still begging on Magic Launcher being discontinued, I cannot change launchers because all of them doesn't remember passwords correctly (as soon the auth token expires, forces me to re-enter the password, duh... its a pain in the ass when you have lots of accounts you've bought) and its locking me up on 1.12.2, even refusing to play on 1.14.x... I hope you can make a small fix to allow 1.13.x and beyond (and maybe up the limit to 200 accounts?) =/

I hope it will support Fabric/LiteLoader/Forge for 1.13.x and 1.14.x if thats possible @sp614x =S

Old comment: I really miss being able to run ML with 1.13's or later.. Let me know if you might able to update/add suggestions cuz im way too attached to it and never switching to any launcher

TNTUP commented 4 years ago

Hi, sorry for being annoying about updates of MagicLauncher. I really love this launcher and I cannot leave it because its so easy to manage MC accounts, versions ect... But since 1.13.x I can't make it work but my workaround I found works with ML but I wish to see ML running 1.13+ versions and snapshots :(

I wish to see it updated for Christmas, and I don't know if account limit can be increased to 200, instead of "lastlogin" files, it could save account creds into a file and encrypts the password

Again, sorry if I'm annoying and I'm still a user of MagicLauncher for years... Hope to see it as a Christmas release and I have no such place where to contact you/Private Message :/ Please let me know even if its unsupported :((

TNTUP commented 4 years ago

@sp614x Sorry if im quite annoying with this, is it possible if with the source code of Magic Launcher to continue using it for my own private uses?

TNTUP commented 4 years ago

Found an alternative. Closing

TNTUP commented 3 years ago

Reopening, the alternative I had used has far more issues so I reverted using Magic Launcher.

I'd pay for it to get updated or updating it for my own uses. I wish to get Vanilla/Optifine and other deratives to work with this launcher... My workaround still works but its a pain to manually edit every newer versions :(

Sp614x, if you see this message, I hope deeply you'll update MagicLauncher when you want (maybe never).. There no suitable launchers for me to use for easy account management, auto-renewing token etc.

The workaround to get vanilla/optifine to work is adding "minecraftArguments" in your version' json file including their parameters to launch. Doesn't work with Forge/Fabric, sadly