sp614x / optifine

1.79k stars 418 forks source link

Connected textures glitched when used with shaders + resource pack [1.14] #2402

Open alexiaestefania opened 5 years ago

alexiaestefania commented 5 years ago

Hello and good day, all.

When using shaders with the 1.14 Optifine previews 5 as well as preview 6 (latest), I noticed that even though Mizuno's new 1.14 resource pack has support for connected textures grass+gravel, when used in combination with shaders, the grass texture turns into a glowing orange square. Of course, when connected textures are set to OFF, the problem does not happen.

Take a look at the IMGUR album which contains the photos I took of this

information on tests:

shaders: SEUS renewed 1.0.0 Chocapic V7.1 from Medium to Extreme Sildur's VIbrant Shaders Extreme VL 1.72 and Extreme VL 1.21

Optifine version: preview 5 preview 6

resource pack: vanilla mizuno 16 pack 1.14

my specs: AMD FX4300 CPU 16GB memory Nvidia gtx 1050

alexiaestefania commented 5 years ago

literally. seconds after i posted this, it somehow fixed itself (in pre6). so, i guess that's that then

AConyl commented 4 years ago

Please reopen the issue, as it persists in OptiFine 1.14.4 HD U F5

Description of Issue

Similar to the above issue. When moving or looking around, the connected texture overlay will flicker:

overlayWhenWalking

Even just looking around will cause it to flicker and not render some parts of the overlay: https://imgur.com/a/C5SvJQX

This issue only occurs when OptiFine AND a resource pack with connected textures AND shaders are being used.

Steps to Reproduce

  1. Install Optifine 1.14.4 F5
  2. Install a resource pack with connected textures (I used Excalibur), the latest 1.14.4 version)
  3. Install a shader pack (I used Sildur's Enhanced Default), latest version)
  4. Make sure you are using the resource pack and that connected textures is set to fast or fancy
  5. Load the shader pack
  6. Observe

OptiFine Version

OptiFine 1.14.4 HD U F5

Installation Method

I was using ATLauncher and I dropped OptiFine JAR file in the mods folder.

Fabric/Forge Version

Fabric 0.7.6+build.181

OptiFabric Version

OptiFabric 0.7.1 (1.14.4)

Other Installed Mods

Log Files/Crash Reports

N/A

F3 Debug Screenshot

2020-03-25_23 33 07

Prior Testing

Obviously the connected texture requires OptiFine. With OptiFine and the resource pack, the overlay is fine and does not flicker. With OptiFine and a shader pack and the resource pack, the overlay flickers when I move or look around.

Additional Information

I made a GitHub account just so I could report this.

AdamBrezik commented 7 months ago

I'm having a similar issue with fabric/iris and continuity/overlay textures I'm thinking it's the way the rendering works with texture layers in this case and it puts those textures into the same layer which results in textures flickering one through another as each time you change the angle the renderer calculates different texture to have priority over the other one. It's not a bug, it's an incompatibility, and a very general one.

I guess it'd be enough to put those textures into another layer, although I have no idea what would that layer be called. The one used in my case is "cutout". I haven't found any source for this enumeration values, if it's an enumeration at all.