search

sp614x / optifine

1.8k stars 418 forks source link

[1.13][Bug] OF Resource Pack Textures disappearing on custom NPC UIs #2590

Open TBlazeWarriorT opened 5 years ago

TBlazeWarriorT commented 5 years ago

When the player interacts with some custom NPCs, OptiFine textures from their current Resource Pack won't work and will be reverted back to the vanilla ones. All custom UIs work fine, except for NPCs. It looks like it's on OF's end.

Example: https://i.imgur.com/2pFPtyw.gif

Details: Server used: Hypixel SkyBlock, talking to Farmer Merchant or any selling NPC Optifine 1.13.2_HD_U_E7 .properties code used example:

type=item
items=minecraft:bow
texture.bow_standby=hurricane_bow.png
texture.bow_pulling_0=hurricane_bow_0.png
texture.bow_pulling_1=hurricane_bow_1.png
texture.bow_pulling_2=hurricane_bow_2.png
nbt.display.Name=ipattern:*hurricane bow*
TBlazeWarriorT commented 5 years ago

Update: I now believe this is because every item when the NPC is open needs a custom tooltip that shows the sell price of that item, so the item gets changed into a weird version of itself that has the alt tooltip. Not sure how OptiFine could deal with it. On the other hand, that bug only happens in Minecraft 1.13, older versions work fine.

TBlazeWarriorT commented 5 years ago

Update2: Seems to only affect nbt.display.Name and similar. nbt.ExtraAttributes.enchantments and such will still work in that menu.