Closed octylFractal closed 8 years ago
Can this be reproduced with less mods. Ideally it should be reproducible with only OptiFine and one ore two other mods. Error log?
Yes, I'm able to reproduce the problem. I'm using the Curse app on macOS Sierra. Modpack is FTB Unstable 1.10. Would love to get this fixed. It's been consistent for a couple of weeks and OptiFine releases. I reported the error on the forum too.
I'm running:
OptiFine_1.10.2_HD_U_D2_pre Forge 12.18.2.2107
Is MC crashing every time or only sometimes? Error log? Which mods are installed? The crash report shows only Forge, OptiFine and CoreChickenLib. Tested with Forge #2099, OptiFine D1 and CoreChickenLib 2.4.2.106, no crashes so far.
MC is crashing every time. How do I get the error log? I have attached a crash report in my previous message.
In the vanilla launcher the error log is shown in the tab "Game output". To keep the launcher open, edit the Forge profile and set "Launcher visibility" to "Keep the launcher open". No idea where it is in the Curse launcher.
crash-2016-10-25_21.46.29-client.txt
Having the same problem.
Maybe osx sierra who is the guilty one ? tho using a MacBook pro with only integrated graphics, and a bunch of mods. Using forge #2099 crash-2016-10-25_21.57.00-client.txt
^without mods
Update1: Testing versions of Optifine now, C1, C3 works with no mods, getting some issues with mods tho. D1, still gets the splash screen error
C3 works and D1 or D2_pre crash? Error log?
Yes, thats correct.
Update: saw that mc multipart had snook its way in there, so removed it, but still the same.
okay i am very very sorry for disrupting the topic and going off topic to 100% but @Crash0 ... good lord how did you do that with the spoiler/summary? i can not find anything in the mark down explanation!
You use (without quotes) <"details"> <"summary "> title <"/summary " > text <"/details ">
Eureka ! Found a solution ! I disabled the FML splash screen in the splash.properties config.
and now it works using the D1, and no mod compatibility issues either !
@Crash0 that is the fix I specified in the OP.
@sp614x I've been busy but I'll try to get you the error log and other stuff with just Forge + Optifine within the week.
Ohh, Im blind. (facepalm) But yeah. The error is reproducible at least.
Error log with Forge 2114 and Optifine D1: https://gist.github.com/kenzierocks/0fab32837ce33a1f9b9e1db7283defe0
Is the latest preview D2 also crashing?
I disabled the FML splash screen in the splash.properties config.
I just tried this, and the game doesn't crash anymore. So the bug is indeed in the splash screen. Haven't had a chance to produce a crashlog yet.
@sp614x Here's the game output you wanted me to supply. This time I had re-enabled the mods, since we have narrowed the problem down to the splash screen only. Still using D2-pre.
I can not reproduce the problem. All combinations of Forge, OptiFine and different mods are working properly for me.
Are you using mac os sierra? java v. 1.8.0_111 ?
I just installed 111, been on 101. Sierra 10.12.1.
Caused by: java.lang.IllegalStateException: Texture creation: Invalid value at net.minecraftforge.fml.client.SplashProgress.checkGLError(SplashProgress.java:815) at net.minecraftforge.fml.client.SplashProgress$Texture.
(SplashProgress.java:682) at net.minecraftforge.fml.client.SplashProgress$Texture. (SplashProgress.java:646) at net.minecraftforge.fml.client.SplashProgress$3.run(SplashProgress.java:247) at java.lang.Thread.run(Thread.java:745)
I have no insight about this particular class, but that sounds like an problem with how textures are displayed/rendered Is there the slightest chance to add in a bit diagnostic code around that line number and give em a more verbose version of optifine to get behind it?
The problem seems to appear only on Mac OS, versions 10.9.5 to 10.12.1. The Forge splash screen is rendering on a background thread and the graphics driver may have a problem with it. This will be complex to fix as I don't have a Mac for testing.
That is an interesting problem indeed. Since you're mentioning background threads and graphics drivers, it could also be related to the MacBook, which has two built-in graphic cards. Is the splash screen rendering on the built-in or the dedicated card?
Anyway. Is there something I can do to help fix this problem?
You could setup a virtual Mac through VirtualBox but that is quite a lot of work, and though I'm familiar with a terminal and the command line I have not been able to create a virtual Mac. It depends on how much you want to get this fixed. I think one community member is willing to give you a VNC remote access to a Mac, so you can debug over the web.
Until it gets fixed, it probably makes sense to let users know that they can edit the splash screen config.
Think i can confirm that the dedicated card is not the problem, i only have the integrated graphics option in my MacBook.
Can you check which is the last OptiFine versions that is working correctly:
As said, the latest version that works is C3 for 1.10.2. Test with respective mc versions or all on 1.10.2?
ok, fun-fact, I've setup a dev environment with deobfuscated version of D1 for 1.10.2, and now the splash screen is entirely disabled. And the splash screen comes back when i remove the deobfuscated jar.
But then again, it wont show the splash screen with any of the deobfuscated vesons of optifine.
Deobfuscated versions functions as normal via launcher, C3 works and D1 crashes.
Are these 2 versions working? http://optifine.net/tmp/OptiFine_1.10.2_HD_U_C4_pre1.jar http://optifine.net/tmp/OptiFine_1.10.2_HD_U_C4_pre2.jar
Pre1 works. Pre2 crashes. Game output
Can you try "Video Settings -> Quality -> Custom Entity Models -> OFF"?
Still crashes.
Is this one better: http://optifine.net/tmp/OptiFine_1.10.2_HD_U_C4_pre2B.jar
Yes, that works !
Updated preview D2 with a bugfix, is it working? http://optifine.net/adloadx?f=preview_OptiFine_1.10.2_HD_U_D2_pre.jar
Yes that worked ! May I ask what the problem was ?
Between C3 and D1 OptiFine added a better way to detect the maximum supported texture size on modern GPUs. It is a modified version of the way vanilla does it. It works by creating bigger and bigger virtual textures until the GPU says "Not possible".
The problem is that some (older) GPU drivers not only respond with "Not possible", but they also raise the glError flag, which is not correct. This is usually not a problem, the next time glError is checked it is automatically cleared.
OptiFine calls the function when initializing and on Mac OS the glError is set. A bit later the forge splash screen starts and tries to create the screen texture. It checks the glError and crashes because it thinks that the texture creation has failed. It could have just log the error and go on. It looks like the splash screen is too sensitive to gl errors.
Vanilla is not calling the function when initializing, so the splash screen can start. Vanilla calls it when loading the texture atlas, the glError is raised, but on the next frame the error is checked, logged and reset, so nothing bad happens.
The bugfix was to clear the glError after the maximum texture detection has finished.
Ok, sounds like it was a easy problem to fix when we found the source of it :) and yeah, OS X graphics are not always best friends OpenGL.
As I understand they use some sort of legacy version, specific to OS X.
By the way, when does this become the new stable version?
They're not legacy drivers, they're just Apple's drivers. Different drivers have different bugs.
Confirmed. It works. Thanks for fixing, @sp614x.
OptiFine_1.10.2_HD_U_D1 Forge 12.18.2.2102
No crash occurs with splash disabled in Forge or without Optifine.
https://gist.github.com/kenzierocks/3b3086c4941fabf13412d29566a9e8d8