Overlay ctm doesn't work with transparent/translucent blocks

sp614x / optifine

1.77k stars 419 forks source link

Overlay ctm doesn't work with transparent/translucent blocks #300

Closed Flambou closed 7 years ago

Flambou commented 7 years ago

It seems like the ConnectBlock and ConnectTile specifications aren't working for transparent blocks e.g. glas or leaves. Also it would be nice to make it possible for all ctm methods to be overlayed with an own tintIndex

sp614x commented 7 years ago

CTM connect by tile and by block should work for transparent blocks. The error log may have more details. Link to resource pack that is not working?

Flambou commented 7 years ago

I didn't meant the connect by tile for ctm. When you use the overlay method you can't specify a transparent block to be the neighbour as an "activator". Either way here is an example resourcepack which shows the problem. https://www.dropbox.com/s/r0x2xk7ao7jsjft/Testpack.zip?dl=0 Also it would be nice to be able to "overlay" (with specific tintIndex) textures when using methods like fixed or random.

sp614x commented 7 years ago

Currently the neighbour can not be a transparent cube. The limit could be removed, then it would look like this: http://i.imgur.com/ciN6xDP.png

Flambou commented 7 years ago

Is there a particular reason why the limit has been implemented? I would really appreciate if it would be removed.

sp614x commented 7 years ago

The limit is a performance optimization and also when the overlay is on a transparent block it is not visible from below which looks strange:

from above: http://i.imgur.com/QGcueIJ.png
from below: http://i.imgur.com/wScqcwn.png

If this is not a problem, the limit can be removed.

sp614x commented 7 years ago

Updated overlays to check for a full cube model instead of opaque cube. It should work for glass, stained glass and ice. Coming in next preview D3.

Flambou commented 7 years ago

Thank you very much :D