search

sp614x / optifine

1.8k stars 418 forks source link

[1.12.2] Emissive textures compatibility issue with Chisel #3475

Open lazarusgreen opened 4 years ago

lazarusgreen commented 4 years ago

All versions of Optifine for 1.12.2 (I suspect later and earlier versions of Minecraft too, but not tested for those) for some reason irreversibly disable emissive textures on all of Chisel's blocks when installed. Other blocks with emissive textures added by Optifine work flawlessly and can be turned off and back on.

Example in screenshots: Chisel's emissive texture blocks compared to a block of ambrosium ore from Aether Legacy with emissive textures added by Optifine.

Screenshot 1: Optifine not installed, Chisel's emissive textures working screenshot1

Screenshot 2: Optifine installed, emissive textures ON, Chisel textures stop working correctly; still animated and properly layered but no longer glowing screenshot2

Screenshot 3: Optifine installed, emissive textures OFF, Chisel emissive textures still not working screenshot3

I haven't found any known fixes for this error and I haven't seen it reported anywhere before. I don't know what exactly causes it, but my best guess is Optifine somehow overwriting Chisel's graphics.

lazarusgreen commented 4 years ago

Update: I attempted to throw together an emissive textures resource pack for Chisel that could fix this issue, though with no real knowledge of how these things work I have no idea if it has any chances of working. In its current state it certainly does not.

If anyone would be willing to help make this work in case this bug doesn't get fixed, I would greatly appreciate that.

Google Drive download link: https://drive.google.com/file/d/1HbUd4fLJaduQlfwCUo7SJ38QW_UeK8bb/view?usp=sharing

sp614x commented 4 years ago

There was an issue about this (modded emissive blocks) with a decription why it can't be fixed. Forge mods were using the forge lighting pipeline in a specific way to force the block brightness which was conflicting with OptiFine.

lazarusgreen commented 4 years ago

There was an issue about this (modded emissive blocks) with a decription why it can't be fixed. Forge mods were using the forge lighting pipeline in a specific way to force the block brightness which was conflicting with OptiFine.

Thank you for the response! Should I leave the issue open in case someone willing to help with the resource pack fix comes by, or is that irrelevant to the board/also confirmed impossible to do? If it's just irrelevant, what's the best place to move the discussion to?

rvveber commented 3 years ago

@lazarusgreen ist the resourcepack working by now? I'd also contribute, but mainly for the antiblocks

btw your issue was that the texturepack is packed as .rar which minecraft cannot read. Make a uncompressed .zip and it will work. For testing purposes you can even just use an unzipped normal folder, that works too.