search

sp614x / optifine

1.81k stars 418 forks source link

[Bug] CIT no longer correctly working/very broken for Tridents #4061

Open DataCrusade opened 4 years ago

DataCrusade commented 4 years ago

Description of Issue

In 1.13.2 Optifine, I was able to give specific Tridents a custom model via CIT, the item was correctly scaled in the inventory slots and it correctly replaced the first and third-person in-hand model, but testing it in 1.15.2 with the latest version (Pre23) it is no longer properly scaled nor does it have the correct appearance (using the same texture as in the inventory slot generated like every other item) in 3rd person. This also affects trying to give Tridents any sort of custom model, not just this specific case, see the attached resource pack.

2020-06-08_09 12 49

trident.zip <- the model used

1.13.0v_VisualEnchantments.zip <- A resource pack that shows off the issue better (not mine)

OptiFine Version

G1_pre23

Cart3r1234 commented 4 years ago

This is actually something that Mojang changed; as of 1.15 trident_in_hand models can not be changed at all, so if this feature could be revived through optifine that would be pretty cool, but I don't know how possible that would be.