sp614x / optifine

1.8k stars 418 forks source link

Error: ConcurrentModificationException (TechReborn+RebornCore) #436

Open ghost opened 7 years ago

ghost commented 7 years ago

is there a way to solve this? using optifine in a modpack. it works well, i don't want to delete it. but how to solve this problem? any option can be disabled to solve this? i searched it on internet, someone solved this problem via closing "connected textures" option. i tried that, didn't worked. this crash happens oftenly. and it's very annoying. please help... using game 1.11.2 using forge 2222 and optifine B6. thanks

sp614x commented 7 years ago

Can you post a link to the crash report?

ghost commented 7 years ago

of course.. tessellate crash.txt

sp614x commented 7 years ago

Crash pastebin: http://pastebin.com/g1r1kKQf

sp614x commented 7 years ago

It crashes in the "reborncore.mcmultipart.multipart.MultipartContainer.getExtendedStates()". No idea how this is linked to OptiFine.

sp614x commented 7 years ago

Can you reproduce it with minimal number of mods installed? For example only Forge, OptiFine and RebornCore?

ghost commented 7 years ago

okay, i will try it now. i'm sorry if it's caused by reborncore and techreborn. but please see this: https://github.com/TechReborn/TechReborn/issues/936 and i know that this crash happens when i put cables or breaking cables. can you help this?

sp614x commented 7 years ago

It is practically impossible to find which of the 90 installed mods is the problem. The only way to fix the crash is to isolated a minimal set of mods (1-2) that still reproduce it. If the crash happens when placing cables, try it with only the mod that adds the cables.

ghost commented 7 years ago

I tried. Tried many, many times, believe me. I tried installing TechReborn+RebornCore only. Cables didn't make any problem. But when install Optifine with it (TR+RC+OF) it crashes sometimes. Maybe you can add an exception for cables in OptiFine to do not tessellate them? And another issue, the new forge version( added in forge 2223) causes missing texture items code names on it, and when installing optifine, game crashes instantly if you see ANY missing-texture items. but when delete the OptiFine, it looks like this: https://cloud.githubusercontent.com/assets/24831406/22164166/c2593ae2-df5e-11e6-9f4a-9664e3ff999f.PNG and someone said that there is a rendering problem with optifine with that texts on items. and optifine should fix it bla bla... Can you fix it please?

ghost commented 7 years ago

and if you want me make this cable-issue crash happen with installing only optifine and techreborn, i will with pleasure.

sp614x commented 7 years ago

So the combination of Forge, OptiFine, TechReborn and TechRebornCore can reproduce it when placing/removing cables? Going to test it. The crash with the new Forge version is known: https://github.com/sp614x/optifine/issues/438

ghost commented 7 years ago

Oh, okay! Thank you so much! And hope the issue #438 be fixed on next OptiFine version. Thanks a lot. Forge + OptiFine + TechReborn + RebornCore = %30 chance to crash

ghost commented 7 years ago

But please know that, the cable bug happens sometimes. It's about %30 of the time. For example, i built a technologic system in my home with cables, moving around in home, no chrash, go somewhere on nature, then teleport to my home:crashed. Or sometimes moving around in my house. Another example of my friend: he said that "i placed copper cable, and break it; then crashed" and i also know that i placed a copper cable with another cable then when break it, game crashed. ALL the crash reports says "Tessellating block in world" or something tessellate thing.

ghost commented 7 years ago

Here is my crash report: crash-2017-01-26_14.47.38-client.txt mods are optifine, techreborn and reborncore. crashed while placing copper cable.

sp614x commented 7 years ago

Tested Forge #2226 + OptiFine B7_pre for 1.11.2 + Reborn Core 2.11.4.1 + TechReborn 2.1.3.54. Placed a lot of copper cable, removed part of it, teleported around, moved around, reloaded chunks - so far everything seems to work, no crashes. Maybe you can post a world that crashes somehow reliably.

ghost commented 7 years ago

OK, i tried with b7_pre with TR and RC, placed ONLY 1 copper cable, then crashed. here is the crash report: crash-2017-01-31_21.53.23-client.txt

sp614x commented 7 years ago

You also have Forestry, JEI and TheOneProbe installed.

ghost commented 7 years ago

they don't really effect this issue. Okay let me try with only optifine and TR+RC wait... tessellate crash optifine and TR.txt Here, only optifine b_7 and TR+RC installed. Placed about 20 cables, crashed.

sp614x commented 7 years ago

You have resource pack and shaders active. Tested again with Faithful 1.11.2-rv3.zip and Sildurs Vibrant Shaders v1.161 Medium.zip. Placed and removed a lot of copper cable, no crash so far. Does it also crash without resource pack and no shaders? You can try "Video Settings -> Other -> Reset Video Settings" and then test again.

ghost commented 7 years ago

OH, okay sorry to forgot that. i will remove minecraft, install forge, optifine and TR+RC now. okay. i will edit this comment. HERE, i deleted minecraft, re-installed, installed forge 2226, mods: optifine b_7, TR+RC. crashed while placing copper cables. i opened debugger profile in optifine settings. i placed about 10-15 copper cables. crash-2017-02-01_16.28.18-client.txt

ghost commented 7 years ago

i really did it very clearly this time.

ghost commented 7 years ago

any hope for it be fixed? =:(