sp614x / optifine

1.81k stars 416 forks source link

Difference between vanilla and shaders sun/moon position #485

Open sp614x opened 7 years ago

sp614x commented 7 years ago

There is a difference between the vanilla and shaders sun position: http://i.imgur.com/veLH6D2.png Shaderpacks SEUS 10.1 Ultra and Continuum 1.1.5 Ultra.

sp614x commented 7 years ago

Tested with Sildurs shaders and SEUS 10, there is a minimal vertical difference between the vanilla and the shaders sun position: http://imgur.com/a/9XECF The moon is also affected: http://imgur.com/J9X32I7 The difference is about 1.6 m which is the Steve eye height.

Builderb0y commented 7 years ago

Is the distance and W value of the sun position correct before being rotated by the model view matrix? In my testing, the distance needs to be 100.0 (which I think it already is) and the W value needs to be 1.0. These are different values than what I originally used in my issue about sun/moon/up positions lagging a frame behind, but that has now been corrected as well.