sp614x / optifine

1.77k stars 420 forks source link

[CIT] type=enchantment just straight don't work #5233

Open nateiscool246 opened 3 years ago

nateiscool246 commented 3 years ago

Description of Issue

I have tried so many methods of .properties files with type=enchantment and it just straight doesn't work. I even went to bare minimum of type=enchantment and texture=no_glint.png and that still didn't work.

Steps to Reproduce

  1. Make a resourcepack with an optifine folder
  2. In the cit folder withing optifine make a .properties file that is type=enchantment

OptiFine Version

Minecraft 1.16.3 OptiFine HD U G5

Installation Method

I installed optifine using the official optifine installer.

Gunging commented 3 years ago

Custom enchantment glints have not worked since 1.14 minecraft. It really sucks :c

PastaLaPasta commented 3 years ago

Has it really been broken for that long? Why haven't it been fixed yet?

TLiG98 commented 3 years ago

Is it possible to have it fixed? Would really love have the feature up and working again. You can do some truly mad shit with it!

Gunging commented 3 years ago

Heck I wish, we used it so much in our RPG server. Straight up looks cool asf, I myself coded a plugin with features to increase the potential of this feature.

Really miss it. The stuff is still there, just waiting

Anslean commented 3 years ago

I would love to be able to have different glint colors for Silk Touch vs Fortune, for Protection vs Blast Protection vs Fire Protection vs Projectile Protection, and for Sharpness vs Smite vs Bane of Arthropods. Maybe Mending vs Infinity, Riptide vs Loyalty/Channeling, and Piercing vs Multishot.

Honestly, I've been wondering whether I should dip my toe into this kind of modding. Maybe I should give this a shot myself. I've got a working version from a previous update to reference. Failing at it would be better than waiting around hoping for it to get fixed, after all.

Edit: It has come to my attention that this is not open-source. RIP enchantment glint and custom shulker boxes.