sp614x / optifine

1.79k stars 418 forks source link

Void part of Custom Skybox doesn't render #5463

Open GamingPro917 opened 3 years ago

GamingPro917 commented 3 years ago

Description of Issue

Whenever you put on a custom skybox, the bottom part/void section doesn't render properly, as the following image shows.

2021-03-20_19 26 09

However. when I disable the Default Sky option, it fixes the void rendering issue but presents a new issue: a washed out sky:

2021-03-20_19 27 55

I remembered seeing someone use this resource pack a couple of years ago with neither problems present, so I went back to that video and looked for him to press F3 to see his Optifine version, which turned out to be version H8. I replaced M5 with H8 and, sure enough, both problems were fixed.

2021-03-20_19 33 18

However, since this is a much older version of Optifine, it doesn't improve performance as much as newer versions and doesn't have the same features. Newer mods are also incompatible with H8.

Steps to Reproduce

  1. Put on Tightfault revamp/Legend27 by palikka (Doesn't have to be these packs, but these two resource packs suffer from both problems, not just the void rendering but also the desaturation.)

  2. Find an area of a server or world where you can see the sky and void.

OptiFine Version

Optifine M5 for 1.8.9 and G7 for 1.16.5

Installation Method

Dropping the JAR into the forge mods folder.

Fabric/Forge Version

11.15.1.2318

Other Installed Mods

Powns ToggleSneak - 3.0 Sidebar Mod Revamp AutoGG-4.0.3 Autotip-3.0.1 BetterFps-1.2.0 Combat Info-1.0 Damage_Tint_2.0 foamfix-0.6.3-law Keystrokes-8.0.2 OldAnimationsMod-Animations & Cosmetics_2.6.5 OptiFine_1.8.9_HD_U_M5 Scrollable Tooltips-1.3 TexFix+V-1.8.9-4.0 Patcher-1.5.1

F3 Debug Screenshot

2021-03-20_19 57 49

Prior Testing

Essentially, no matter what way I play Optifine, these issues persist.

In Vanilla these issues persist as well.

GamingPro917 commented 3 years ago

I came across some more details regarding this issue:

I was playing Hypixel Skywars when I realized that when I fell into the void, the void started rendering properly for a brief moment. I found out that around -3 on the Y axis made the void render how it should from higher up:

2021-03-27_13 26 39 At -2 on the Y axis 2021-03-27_13 26 42 At -3 on the Y axis

I have no idea whether any of this information is useful but it was something interesting I found.

tuyertw-github commented 3 years ago

this bug started in 1.8.9 I7