search

sp614x / optifine

1.81k stars 418 forks source link

[Mod Incompatibility MC 1.16.5] Missing texture of Naga and Hydra #5535

Open TheDarkRisen opened 3 years ago

TheDarkRisen commented 3 years ago

Description of Issue

There is some bug report on Twiligh Forest GitHub https://github.com/TeamTwilight/twilightforest/issues/1023 https://github.com/TeamTwilight/twilightforest/issues/1030 https://github.com/TeamTwilight/twilightforest/issues/1038

Steps to Reproduce

  1. Instal Twiligh Forest and OptiFine
  2. Find Naga or Hydra

OptiFine Version

I tested all three version for 1.16.5

Installation Method

Just droped .jar into "mods"

Fabric/Forge Version

Forge 36.1.0

TheDarkRisen commented 3 years ago

One more report https://github.com/TeamTwilight/twilightforest/issues/1017

Liamdude commented 3 years ago

For some context, one of the mod developers took some screenshots that show what is happening with the Hydra specifically. 2021-04-07_17 34 04 2021-04-07_17 32 34

DereC4 commented 3 years ago

Occurring here too with naga. Bounding boxes aren't affected and I believe this is a modeling conflict

MarioSMB commented 3 years ago

Any updates on this would be highly appreciated. According to the Twilight Forest developer, OptiFine's use of overrides and custom class loaders to prioritise itself over Forge are preventing any workarounds on TF's side, and their team is being barraged by users with reports of this problem.

Azar2477 commented 3 years ago

Good thing that @TeamTwilight knows.

officialjrem commented 3 years ago

Any update on this issue?

DereC4 commented 3 years ago

Would like to know too

officialjrem commented 3 years ago

Also happens with the snow queen, her cage doesn't show up.

sergeycherepanov commented 2 years ago

Hi, any updates according to the issue?

MarioSMB commented 2 years ago

I am genuinely surprised to find out this major mod incompatibility is still open after almost a year...
Limited information has been provided as to the details of the issue or potential workarounds - turning on Smart Animations is supposed to help with crashes.

It appears to be related to multi-part objects, is there no alternative way Twilight Forest could handle them that would be compatible with OptiFine, or is this actually a missing function in OptiFine itself?

Cicopath commented 2 years ago

This is a problem with OptiFine itself; there is no way around it unless the developers of OptiFine stop replacing Minecraft/Forge code with their own, making many mods incompatible. Indeed, many popular mods, such as Tinker's Construct; Ars Nouveau; and, of course, Twilight Forest; have missing textures or have the world crash due to this. It is not the mod developers' responsibilities to fix OptiFine's problems.

Overall, it would be best to remove OptiFine, remove the mod that is being affected, or just accept that your world won't look as appealing or you can't use certain modded features.

DereC4 commented 2 years ago

A small price to pay for salvation

MarioSMB commented 2 years ago

Unfortunately it isn't so clean-cut; OptiFine has a monopoly on the performance-enhancing scene, without it the game can be unplayably laggy with several mods in play. If one has to choose between decent performance and this mod, I'd dare say a majority of the playerbase would choose performance.

Truly it is a shame to hear that there are no workarounds other developers can apply for such issues, this is a case where #5576 would be useful.
Regardless of whose responsibility it is to fix this, it is an issue that is causing the two mods to be incompatible - a worse case than minor visual bugs or rare crashes.

Here's hoping someone from the OptiFine team can take a look at this and allow workarounds or outright solve the issue; presumably it is a problem with the custom renderer code.

MarioSMB commented 1 year ago

Seeing as we're about to enter the second year of this issue being open, I'm going to do the community a favour and point out the alternatives:

My heart aches for the Twilight Forest team who have been impacted so heavily by this, they have needed to add messages about OptiFine in as many places as possible whilst still being barraged constantly by complaints about the incompatibility all this time.
This is a true showcase of the failings of being a closed source mod in an open community, and as the alternatives show it most certainly is unnecessary.