search

sp614x / optifine

1.81k stars 418 forks source link

[CIT] Allow specifying a custom enchantment glint texture override #5562

Open SeaOfPixels opened 3 years ago

SeaOfPixels commented 3 years ago

A new optional line in the .properties file for custom items (CIT), that allows custom enchantment glints to be assigned by specifying the file path (same structure as the 'texture=' file path specification for the base texture).

This would allow creators to personalize their custom items further, and is something I'd really like to see personally. Custom items can feel washed out when enchanted, so being able to assign a unique enchantment glint texture that complements that item rather than overtaking/outshining it would be a huge improvement to CIT.

Again, this would be an optional parameter. Given this 'texture.enchanted_item_glint' is not specified by a user, it will simply default to the default enchanted item glint.

Cart3r1234 commented 3 years ago

I'm almost certain this is already possible in versions below 1.15, but is broken in 1.16 and up

SeaOfPixels commented 3 years ago

Pretty sure it was possible to specify it by enchantment, but not by the cit item itself. Having both options would be best (both item-dependent and enchantment-dependent).

Cart3r1234 commented 3 years ago

If I'm not mistaken, by using type=enchantment you could specify a replacement glint texture. I'd check the documentation, but I'm fairly sure its a thing already

Anslean commented 3 years ago

@Cart3r1234 is correct. It's in the documentation, and there are working datapacks utilizing this feature for previous versions of Minecraft/Optifine. Unfortunately, it's currently not working in 1.16. I've been agonizing over this for about 8 months, but nobody on the dev team has responded to any of the bug report issues 🙁

Cart3r1234 commented 3 years ago

the dev team Well, optifine is developed solely by sp614x, and since there's only one person developing, bugs that aren't very gameplay-impacting like this one are probably lower down in priority to be fixed unfortunately. Hopefully one day this one does get fixed though, along with the other major resource pack bugs.