sp614x / optifine

1.8k stars 418 forks source link

[Shader Issue] Sky Flickering and Turning Black. #5925

Open BuckPrivate opened 3 years ago

BuckPrivate commented 3 years ago

Description of Issue Sky seemingly randomly turns black when looking at sky, though sometimes not even whilst looking at the sky. Issue seems to occur when looking at one of several points radiating out from the sun while the sun sets. These points are not visible, but you'll know you're looking at one when the sky changes. The points do not stay in one place, but rather follow the sun as it sets, and you can follow them to keep the sky black.

2021-06-28_14 05 28 2021-06-28_14 05 25

Steps to Reproduce

  1. Launch Minecraft
  2. Wait until dusk, then focus crosshairs at a number of points around the sun
  3. Observe the sky flashing black, then return to normal as the sun sets.
  4. Sky can remain black by following the point as the sun sets.

OptiFine Version 1.17 HD U G9 pre24

Installation Method Standalone installer

Other Installed Mods Sildur's Vibrant Shaders 1.29 Extreme w/ Volumetric Lighting

F3 Debug Screenshot 2021-06-28_14 15 16

Prior Testing

Additional Information Smaller, similar black shadows are present occasionally when aiming at blocks during a similar time of day, but are limited to the borders of the block aimed at. Turning "Fast Render" off fixes this, but has no effect on the sky blackening issue.

Whitelisted1 commented 3 years ago

I would assume this would be a shader issue, considering shaders are still pre and are not finished for optifine yet, so I would wait for that to come out

KaiAF commented 3 years ago

Try turning off Render Regions and Smooth FPS and see if that helps.

BuckPrivate commented 3 years ago

Turning off Render Regions and Smooth FPS seems to have had no effect. It seems to only happen when the sun is setting, and the stars are just starting to come out. Once the stars are out, though, the sky will not turn black or flicker.

KaiAF commented 3 years ago

See if this was fixed in the latest preview version. (pre 26)

BuckPrivate commented 3 years ago

Currently running pre32, I haven't noticed it yet. The linked issue (#5910) still does happen, though.

Edit: Upon further review, this is still an issue.

BuckPrivate commented 3 years ago

Just wanted to see if you guys are still tracking this issue. It's still ongoing in pre33.

CaseRocker commented 3 years ago

I have tested silders vibrant shader in the latest Optifine build for pre33 against the latest build for Iris and the same sky going Black is not happening with the change of day in Iris but it IS happening in Optifine. Also in the End the sky is bright white in Optifine but not in Iris. So it would seem this is an Optifine issue and not a shader issue.

CaseRocker commented 3 years ago

Minecraft_ 1 17 - Multiplayer (3rd-party Server) 8_17_2021 7_44_14 PM

This is the End sky when using Optifine.

fayer3 commented 3 years ago

the issue here, for the black sky, is that optifine writes the fog color to colortex0, even though sildur discards the sky by writing vec4(0.0) to gl_FragData[0] in gbuffers_skybasic.

Sildurs-shaders commented 3 years ago

Fixed by filling alpha with 1.0 in skybasic.

SkarletShadows commented 2 years ago

Still having this issue with shaders causing black sky as described by OP; Optifine Version: OptiFine_1.17.1_HD_U_G9 Shader: Sildurs Vibrant Shaders v1.29 {Any} Resource pack: Mizunos 16 Craft JE_1.17.1-1.0

Cheeky974 commented 2 years ago

The sky going black issue is already fixed and the fix is already above your comment.

SkarletShadows commented 2 years ago

I don't see that setting anywhere? or I'm misunderstanding something

fayer3 commented 2 years ago

you misunderstood. The fix is on the shader side, and will be included in the next version of sildurs vibrant shader.

SkarletShadows commented 2 years ago

I did misunderstand, thank you for helping me understand better :D