search

sp614x / optifine

1.81k stars 418 forks source link

Dynamic light doesnt illuminate blocks with ambientocclusion off #6052

Closed GeForceLegend closed 1 month ago

GeForceLegend commented 3 years ago

Description of Issue

Dynamic light doesnt illuminate blocks with "ambientocclusion":false in block model

Steps to Reproduce

Create a block model with "ambientocclusion":false Load this model in a resource pack Place this block in darkness, and hold a light source in hand

OptiFine Version

1.16.5 G8

Installation Method

Included standalone installer

Log Files/Crash Reports

Nothing special in log and no crashes

F3 Debug Screenshot

Ambientocclusion on: 2021-07-18_09 52 03 Ambientocclusion off: 2021-07-18_09 51 38

sp614x commented 3 years ago

Many vanilla models use "ambientocclusion":false and work correctly with dynamic lights. For example: door, lever, ladder, etc.

GeForceLegend commented 3 years ago

Appears in 1.17 G9 Pre35 too. Maybe only affect full or/and opaque blocks?

GeForceLegend commented 1 month ago

Still exist in latest 1.21.1 previews. Looks like only full opaque blocks (or blocks that will create ambient occlusion around themselves) are affected? Using a same model for glass block and note block, only note block is not affected by dynamic light.

Resourcepack in testing: Test.zip

2024-09-18_09 52 13

sp614x commented 1 month ago

Fixed in 1.21.1, coming in next preview.