[1.16.5] Project Red lamp shader crash

seancrain commented 3 years ago

https://github.com/MrTJP/ProjectRed/issues/1664

Description of Issue

If you try to remove a lamp while also running shaders, the game will crash.

Steps to Reproduce

Make sure you have a shader enabled other than the internal one
Put lamp down in world
Attempt to remove said lamp
Game crash

OptiFine Version

OptiFine 1.16.5 HD U G8

Installation Method

JAR dropped into mods folder

Fabric/Forge Version

Forge 36.2.2

Other Installed Mods

Modpack in question is Telkit: https://www.technicpack.net/modpack/telkit.635727 Ambient Sounds 3.1.9 Applied Energistics 2 8.4.0 Architectury 1.20.28 AttributeFix 10.1.3 AutoRegLib 1.6-49 Biomes O Plenty 13.1.0.482 Bookshelf 10.2.15 Borderless Window 1.2.0 Caelus 2.1.3.1 Carpet Stairs 1.4.7 CBMultipart 3.0.2.119 CC-Tweaked 1.98.0 CeilingTorch 1.13.2 CFM 7.0.0pre22 CGM 1.0.1 Chisels and Bits 0.3.4 Cloth Config 4.11.26 Clumps 6.0.0.25 CodeChickenLib 4.0.2.429 CoFH Core 1.3.1 Colytra 5.1.1.1 Comforts 4.0.1.1 Controlling 7.0.0.23 Create 0.3.2c CreativeCore 2.2.0 CTD Core 2.1.1 Curios 4.0.5.2 Curious Elytra 4.0.2.3 Decorative Blocks 1.7.2 Default Options 12.2.1 Double Slabs 3.5.5 EditSign 2.2.1 ElevatorID 1.7.13 Ender Storage 2.8.0.168 Extended Lights 3.3 Extreme Reactors 2.0.23 Fairy Lights 4.0.5 FallingTree 2.11.5 FancyMeny 2.2.0 FastFurnace 4.4.0 Fast Leaf Decay 25 FastWorkbench 4.5.1 Flywheel 0.2.0 FPSReducer 1.20 FTB Library 1605.3.1-54 HWYLA 1.10.11-B78 Iron Chests 11.2.13 Iron Shulker Boxes 5.1.11 JEI 7.7.1.116 JEI Integration 7.0.1.15 Konkrete 1.1.6 Mantle 1.6.115 McJtyLib 5.0.22 Mekanism (all modules) 10.0.21.448 Mo Glowstone 2.1.0 Mo Glowstone Lamps 1.1.0 More CFM 1.3.1 NetherPortalFix 7.2.1 Obfuscate 0.6.2 OptiFinder 1.16.5 HD U G8 Patchouli 53.1 PeacefulSurface 4 Placebo 4.5.0 ProjectE 1.0.1B ProjectRed (all modules) 4.10.0 Quark Oddities 1.16.3 Quark 2.4-316 RandomPatches 2.4.4 ReAuth 3.9.3 RFTools Base 2.0.11 RFTools Builder 3.1.1 RFTools Control 4.0.11 RFTools Dimension 7.0.11 RFTools Power 3.0.9 RFTools Storage 2.0.13 RFTools Utility 3.1.1 Scorge 3.1.3 Sit 1.3.1 Solar Flux Reborn 16.2.5 Sound Device Options 1.4.2 Sound Filters 0.14 TerraForged 0.2.13 Thermal Cultivation 1.3.0 Thermal Expansion 1.3.0 Thermal Foundation 1.3.1 Thermal Innovation 1.3.0 Thermal Locomotion 1.3.0 Tinkers Mechworks 2.2.5 Vanilla Builder's Extension 1.0.14 Vehicle Mod 0.45.2 VoxelMap 1.10.2 WAWLA 8.0.4 WorldEdit 7.2.5 XercaMod 1.1 XercaMusic 1.4 XercaPaint 1.0 YogMod 2021.06.26 ZeroCore2 2.0.21

Log Files/Crash Reports

https://www.nosiphus.com/minecraft/crash-reports/crash-2021-08-03_09.51.59-client.txt

F3 Debug Screenshot

https://www.nosiphus.com/minecraft/crash-reports/2021-08-03_11.00.03.png

Prior Testing

If you've installed using Forge/Fabric:

Does this happen without other mods installed? The issue is caused by a conflict with the way shaders are handled around ProjectRed lamps. In addition, the issue will not occur if no shaders are enabled.
Does this happen without any mods at all? No.

Additional Information

The internal shader does not cause this problem, so it's not shaders themselves, it's a certain feature that the Complementary Shaders and SEUS both utilize. I would assume BSL is probably broken too since Complementary builds from it.

Dare0900 commented 3 years ago

I can confirm this occurs with BSL too. Seems to be something to do with how optifine handles shader shadowmaps (?)

seancrain commented 2 years ago

An update on this issue: it can be fixed by disabling the halos generated by lamps.

In ProjectRed.cfg, go to the Number of lights to render settings, and set it equal to 0.

sp614x / optifine