sp614x / optifine

1.8k stars 418 forks source link

[MCPatcher] Three missing/broken things. #6299

Open Numpty-Clodpole opened 3 years ago

Numpty-Clodpole commented 3 years ago

Regarding the first one, the texture pack creator "Misa" made this to demonstrate the issue:

image

The other two are just things I'm aware of, which Misa talked about being missing/broken.

She doesn't seem to want to report issues herself, so I'm trying this. She also is rather unwilling to explain in detail about most of the broken MCPatcher stuff, due to her believing they'll never be fixed. Hopefully something can be done.

Edit:

Misa linked me to where she had a lengthy conversation in another Discord server about CTM, which may help explain the issues better.

Here:

(testing a "spoiler" to prevent spam; click the text below to expand the screenies)

<!DOCTYPE html>

Misa CTM chat. (testing this "spoiler" function) ![image](https://user-images.githubusercontent.com/19168008/137010054-7e750ee7-efc7-4b00-b134-9ab847457ac7.png) ![image](https://user-images.githubusercontent.com/19168008/137010090-31e94367-7d58-45c7-b05c-636346d1ac2d.png) ![image](https://user-images.githubusercontent.com/19168008/137010103-2ec5d1ce-f5bd-4493-ad40-f9245767d042.png) ![image](https://user-images.githubusercontent.com/19168008/137010173-0dc19e2a-5d9d-4976-8ade-e4fd1e264d91.png) ![image](https://user-images.githubusercontent.com/19168008/137010186-97b78d65-d6b6-4be4-9310-a7fff3b24dcb.png) ![image](https://user-images.githubusercontent.com/19168008/137010199-f6c12c37-fa1d-43a0-8c4a-769665c7c68d.png) ![image](https://user-images.githubusercontent.com/19168008/137010208-e1bcf4aa-a503-4e2e-97fc-063d6a7250fb.png) ![image](https://user-images.githubusercontent.com/19168008/137010220-3634dea1-3d3f-44ed-99a4-baa38ced3ad3.png) ![image](https://user-images.githubusercontent.com/19168008/137010233-d61b10a8-8b73-40f0-8de4-a30d37aa10c5.png)
WantedRobot commented 3 years ago

not a bug works fine when u set the connect to state look here image

Numpty-Clodpole commented 3 years ago

not a bug works fine when u set the connect to state look here

Unfortunately @WantedRobot, you are mistaken. I shared your reply (along with the screenshot) with Misa, and she said this:

Adding connect=state to method=h+v or v+h does literally nothing at all to fix the issue. His example was of rotatable orientation blocks. h+v/v+h has nothing do with anything he posted. h+v and v+h simply does not work at all as it was designed (incidentally by me), and adding that flag does literally nothing to make it function as intended. It appears he looked at the picture and assumed this was for orientable blocks that use the vertical OR horizontal methods, not the v+h or h+v methods. He's comparing apples and oranges.

The method is unique in that the secondary attribute only kicks in with a single block width and resets the rules to treat it as its own self-contained rule, until overridden by a block width of >1. Optifine fails to reset the rule and treat the secondary attribute as its own self-contained rule, instead, treating primary method blocks as a part of the starting tile in the secondary method's sequence.

She then asked this:

ask him for an example that actually uses the h+v or v+h methods on a block that has no placement orientation.