sp614x / optifine

1.78k stars 419 forks source link

[1.17.1] [Shaders] sunset and sunrise has harsh transition with sildurs enhanced default #6376

Open fayer3 opened 2 years ago

fayer3 commented 2 years ago

Description of Issue

the sunset and sunrise, which usually have a smooth transition into the sky, have a harsh transition when using sildurs enhanced default

Steps to Reproduce

  1. enable sildurs enhanced default
  2. change time to 13500
  3. see that the sunset transition is not smooth

OptiFine Version

1.17.1_HD_U_H2_pre1

Installation Method

standalone installer

F3 Debug Screenshot

2021-11-10_21 51 29

fayer3 commented 2 years ago

I think this has to do with the alpha discard being to high. doing no discard in gbuffers_skybasic seems to fix this.

mgrzyb99 commented 2 years ago

@fayer3 Could you tell me how to edit the code to achieve that?

fayer3 commented 2 years ago

add alphaTest.gbuffers_skybasic=off at the end of the shaders.properties file