[CIT][1.18.x] Armor with NBT-based rule is not applied to armor when worn by a mob

[eccentricdevotion]

Description of Issue

I have been using Optifine for a number of years to retexture armor for my TARDISWeepingAngels Spigot server plugin I equip zombies and skeletons with armor with a custom display name, then use Optifine's CIT to use a new texture. The CIT property files all look similar to:

type=armor
items=minecraft:iron_chestplate
texture.iron_layer_1=cyberman1.png
nbt.display.Name=Cyberman Chest

If I comment out the NBT rule the custom armor textures work, but of course are applied to all iron armor.

The image below shows issues with NBT rule enabled - the helmet and arms are vanilla custom item models This image shows the result of commenting out NBT rule and reloading resource pack

Steps to Reproduce

1. Install Spigot/Paper server
2. Install TARDISWeepingAngels plugin
3. Install TARDISWeepingAngels Resource Pack in Minecraft client - RP on GitHub
4. Spawn in a Doctor Who monster /twa spawn CYBERMAN

OptiFine Version

OptiFine_1.18.1_HD_U_H4

Installation Method

Standalone installer

Other Installed Mods

No other mods

F3 Debug Screenshot

Prior Testing

• Not possible in Vanilla without OptiFine
• Working in previous versions of Optifine (though not 100% sure about 1.17.x) - The Bukkit plugin page shows plenty of screenshots

[eccentricdevotion]

~Seems to be resolved by changing:~ nbt.display.Name=Cyberman Chest to nbt.display.Name=ipattern:*cyberman*

[eccentricdevotion]

So the issue seems to be when a mob is wearing the armour - the NBT rule is applied correctly when a player wears the armour, but not when, for example, a zombie does.

[eccentricdevotion]

Seems to be related to operating system / chipset...

Working OK on WIndows 10 NOT working on macOS with M1 chip / graphics processor

[eccentricdevotion]

Also related (working on Win10, not on macOS) the following CTM rule:

method=fixed
matchBlocks=minecraft:iron_door:half=upper
tiles=tardis_door_upper_inside.png
biomes=minecraft:the_void

[eccentricdevotion]

Happy to do testing on an M1 Mac :)