sp614x / optifine

1.79k stars 418 forks source link

[CIT] Rendered Models in Inventory by CIT are always dark. #6559

Open Ghiojo opened 2 years ago

Ghiojo commented 2 years ago

Description of Issue

When you change an item's model with CIT, by doing the model=(model name), the new model renders much darker than intended in the inventory, which is something that has been happening for several versions, including the latest 1.17 one. Here's an image of what it looks like: image The left texture is a model change, due to it being a pressure plate, the right one is a normal item texture, they should both be about the same color.

Steps to Reproduce

  1. Make a resource pack with optifine CIT
  2. Make it so the item with a name, let's say "test" gets replaced with a model. Any model, Wether it's a remodeling of a vanilla item, or anything of the sort.
  3. Open MC and get yourself the CIT item, you'll notice the item looks like it was always darkened.

OptiFine Version

Optifine_1.17.1_HD_U_H1, though this has been happening since 1.15 and even 1.16 in every version, including the latest ones.

Installation Method

Standalone installer.

F3 Debug Screenshot

image

Prior Testing

Additional Information

Not much, really, it's a self-explanatory bug I believe, just change an item into a model with CIT whenever the item is named in any way, look in your inventory, boom, you need eye bleach now. I hope this is something fixable, because it's a very frustrating thing to see.

Cart3r1234 commented 2 years ago

You can change the lighting direction for the replacement model by changing its GUI display settings. If you're using blockbench, there's a dropdown menu to change it.
image

Ghiojo commented 2 years ago

You can change the lighting direction for the replacement model by changing its GUI display settings. If you're using blockbench, there's a dropdown menu to change it. image

Oooh my god. I just never realised that exists, thank you very much!