search

sp614x / optifine

1.81k stars 418 forks source link

[Bug / Feature?] Custom Sky on multiverse end worlds #6804

Open chrisgdt opened 2 years ago

chrisgdt commented 2 years ago

Hello, this is a bug or a Feature request, according to the feasibility of this.

Actually, when I stand on the default end world (the <world>_the_end, where is the default world in the server.properties), the sky box is sky/world1. However, when I stand on an end world that is not the default end world, generated with Multiverse in my case, the sky box is from sky/world0. Optifine considers this end world as overworld and not end, so the sky sent is the world0.

Is it possible to change that ? Does Optifine has a way to detect the environment of a world (END, OVERWORLD, NETHER) althought it is not the default world ? I know it is possible to get the id of world generated by mods (ids that are not -1, 0 nor 1), but here worlds are considered as overworld, so id 0.

If it is not possible, the doc should be updated to precise that other values are not available for Multiverse worlds.

Thank you in advance.

(Tested with every single version of Optifine 1.17.x and 1.18.x.)

saturnux commented 1 year ago

this bug is still present in 1.20.1 it is only present on multiplayer servers. changing based on 'end' biome doesn't work either. the end should be dark but is not, the only solution is to deactivate the sky. But in multiplayer it's an advantage to have daylight in the end. Certainly it's not a functional bug, but a disturbing one that changes the structure of end maps in multiplayer.

we lose the custom sides of the resource pack. if only we could use biomes but they don't work either.