sp614x / optifine

1.81k stars 416 forks source link

Can't assign different textures to colored Shulker Boxes with custom model #717

Open ImGamez opened 7 years ago

ImGamez commented 7 years ago

Since its only one model name defined for the Shulker Box (shulker_box), it override all the color variants, since in-game are different blocks (white_shulker_box, purple_shulker_box, magenta_shulker_box, etc), it would be good to define them as separate models (if it's possible), or a way to assign different textures depending on the box color in the .jpm file (as far i know there is no way to do that already, if there is already a way to do that let me know how). Thanks!. Pictures of what I mean: 2017-06-21_20 30 08 2017-06-21_20 30 59

EskiMojo14 commented 7 years ago

If you delete the texture reference in the JPM, e.g. "texture": "shulker_box",, the model uses the default entity texture. This is how you can use Randomobs with CEM, and also how you can keep the colours.

ImGamez commented 7 years ago

Thanks that solved my problem, because i only wanted to change the model keeping the textures, i think that in the cem_part.txt documentation, should be added a new line next to "texture" saying if you omited that property the model will use the default texture.

Anyway, i think that the possibility of modify each shulkerbox color model individually would be nice! (if it would possible), Thanks!

sp614x commented 7 years ago

The documentation already states that only the elements "models" and "part" are required. All missing elements take the values from the vanilla model. https://github.com/sp614x/optifine/blob/master/OptiFineDoc/doc/cem_model.txt#L86