sp614x / optifine

1.79k stars 418 forks source link

[Compatibility] 1.19.2 Incompatible with IC2 Classic #7186

Open bdani0717 opened 1 year ago

bdani0717 commented 1 year ago

Description of Issue

Optifine 1.19.2 H9 crashes on launch when installed with IC2 Classic together.

Steps to Reproduce

Launch minecraft with optifine and ic2 classic installed.

OptiFine Version

Optifine 1.19.2 HD U H9

Installation Method

Optifine was installed in the mods folder with forge.

Fabric/Forge Version

Forge 43.1.57

Other Installed Mods

Optifine 1.19.2 HD U H9 IC2Classic 1.19.2 2.0.2

Log Files/Crash Reports

https://pastebin.com/CU6VjzTj

Prior Testing

Both Optifine and IC2 Classic work without the other.

CaptainGlac1er commented 1 year ago

OptiFine HD U H9 was built with Forge 43.1.1 and even OptiFine HD U I1 pre4 is only built with 43.1.52. I know of one breaking change with the push command. So pretty much optifine needs to release another version for 43.1.57 This was a small fix I had to modify the mods to work in optifine. image

SamuX99 commented 1 year ago

OptiFine HD U H9 was built with Forge 43.1.1 and even OptiFine HD U I1 pre4 is only built with 43.1.52. I know of one breaking change with the push command. So pretty much optifine needs to release another version for 43.1.57 This was a small fix I had to modify the mods to work in optifine. image

Which file is the one you have modified and from which mod? I searched in the IC2 classic repo but I can't find it.

CaptainGlac1er commented 1 year ago

@SamuX99 This was the related mod shown in the screenshot. https://github.com/BluSunrize/ImmersiveEngineering/blob/86211504ad15b866e6df4685eb16c239cd6f16bb/src/main/java/blusunrize/immersiveengineering/client/render/IEOBJItemRenderer.java#L102

CaptainGlac1er commented 1 year ago

I think this was the forge update that breaks when optifine overrides the mods forge version. https://github.com/MinecraftForge/MinecraftForge/pull/9083

viktor-ferenczi commented 9 months ago

OptiFine on 1.19.2 is still broken. Some mods are not available for 1.20 yet, so I'm stuck there while playing with my daughter. Have you found any fixes?