sp614x / optifine

1.8k stars 418 forks source link

[CIT Textures] 1.19.3 Internal entity textures not loading when used in CIT #7272

Open isaaclepes opened 1 year ago

isaaclepes commented 1 year ago

Description of Issue

I have a resource pack that replaces paper items with custom models for TradingCards (spigot plugin). It works flawlessly in 1.18.2 and 1.19.2, but when used with the 1.19.3 pre-release version, it fails to load entity textures.

For example, this one should load textures from Minecraft for the zombie horse, deepslate copper ore, grass block, and gold block as well as a custom texture for the nameplate.

"textures": {
    "1": "entity/horse/horse_zombie",
    "2": "block/deepslate_copper_ore",
    "3": "item/horse/horse_zombie_nameplate",
    "4": "block/grass_block_side",
    "7": "block/gold_block",
    "particle": "block/deepslate_copper_ore"

In 1.19.2 it looks like this image

In 1.19.3 it looks like this image

If I edit the model file to point to any other entity texture, the same issue occurs. If I modify the model to use a block texture for the missing texture, it renders the block texture.

Steps to Reproduce

  1. Setup a spigot type server with TradingCards plugin: https://github.com/sarhatabaot/TradingCards
  2. Configure your client for 1.19.3 with the pre-release OptiFine
  3. Add this resource pack to your client: https://github.com/isaaclepes/TradingCardsResource/
  4. Join game and acquire any card or use the "/cards give" command

OptiFine Version

OptiFine 1.19.3 HD U I2 pre3

Installation Method

Download JAR and execute it. Press install and wait until it confirms it was completed.

image

Fabric/Forge Version

N/A

OptiFabric Version

N/A

Other Installed Mods

None

isaaclepes commented 1 year ago

One of our users reported that if you change the item from paper to book, OptiFine is able to display the textures correctly.

image image

The default for the TradingCards plugin is to use the minecraft:paper item as it's basis, though. I wanted to share in case this helps your team narrow down the issue.