sp614x / optifine

1.8k stars 418 forks source link

[BUG] [CPM] Playermodels don't show on "NPC Players" #7412

Closed heinrich26 closed 1 year ago

heinrich26 commented 1 year ago

Description of Issue

CustomPlayerModel parts applied to will not show on custom player entities of that same player, for example created by a plugin. However the Vanilla cape does, as seen in the screenshot.

I suppose it has something to do with how CPM decides who to apply the model to. I just briefly looked at the code and saw it referring to some Player.clearName, which probably works differently to the vanilla cape stuff. (I didn't look into the handling of the vanilla cape) It does however apply to whatever name the NPC is given, e.g.: Player.cfg shows on the NPC named Player.

If you want to test this, on gommehd.net there's an NPC with your Skin in the spawn lobby. (Didn't bother setting up a Server)

image (Left is the NPC, just with the vanilla cape, on the right is the actual player, showing the OptiFine Cape and CPM Parts [Hat and Solid Head Overlay])

heinrich26 commented 1 year ago

Negligible inconsistency