[BUG/1.20.1] Bugged render with 64x64 or any square armor texture

Sto3IV commented 10 months ago

Description of Issue

Armor from different minecraft mods displaying incorrectly: Botania, Ars nouveau, Twilight Forest, Cataclysm.

Steps to Reproduce

Install Any NeoForge/Forge Install any Botania/L_Ender Cataclysm/Ars Nouveau or any mod with square texture file. Install Optifine.

What do you do... Press E or F5 to look on myself.

OptiFine Version

OptiFine HD U I6

Installation Method

Exctracted to mods folder.

Fabric/Forge Version

NeoForge 17.1.87

Other Installed Mods

Tested with only Optifine and Twilight Forest, only with ars nouveau+baubles and optifine, also this bug appears with Botania, baubles+optifine.

Log Files/Crash Reports

https://paste.gg/p/anonymous/3e21235367fc453dbc6bd608b0dffdf4

F3 Debug Screenshot

https://media.discordapp.net/attachments/650083922029445155/1196831845011177582/2024-01-16_18.01.00.png?ex=65b90f83&is=65a69a83&hm=831f35a7c2e3679e150ac84d67630cb2cc4e99f8b51d57ff48a4006ce4e034e8&=&format=webp&quality=lossless&width=884&height=468

Additional Information

I reported this bug on some mods GitHub packes, but they told me that if it works without optifine, that it's theproblem with optifine itself. Because Optifine is closed source so they can't know exactly what causes the problem.

PaleKemono commented 10 months ago

I'm having the same issue

Sto3IV commented 10 months ago

I digged deeper and found that this bug happened if %any% mod have square armor texture like 512x512 or 64x64 it displays buggy. But if mod have regular 64x32 or 128x64 texture of armor it displays properly(aether mod have those). So I think may be optifine trying to render any texture like it was horizontal. Changing texture with Photoshop and putting it in resourcepack didn't help. Any solutions?

Jiingy commented 8 months ago

The screenshot link no longer works. Can you provide a new one?

Sto3IV commented 8 months ago

Here it is. 2024-03-06_02 49 01

tvpv2 commented 4 months ago

Yes, I play with l'ender cataclysm and ars nouveau mods and I have the same problem. It's not like it can be ignored. Disabling optifine solves the problem, but I am not inclined to disable optifine, which is an important performance and fps mode. You should report this to optifine's development team...

tvpv2 commented 4 months ago

very understand

tvpv2 commented 4 months ago

Normal vanilla Minecraft supports both textures where the height and width are equal and where the height is half the width. but optifine may be modifying this. It is annoying that optifine, the most important mod on the market, causes such problems and conflicts with most mods with advanced rendering systems. Fortunately, there is no incompatibility problem with Cracker's wither storm mod. If you are playing this mode, just turn off smooth stack loading in optifine performance settings.

sp614x / optifine