search

sp614x / optifine

1.77k stars 420 forks source link

Custom colors colormaps get randomized (optifine 1.20.6) #7676

Open Emfire12345 opened 3 weeks ago

Emfire12345 commented 3 weeks ago

Tested with OptiFine 1.20.6_HD_U_I9_pre1 Features in question are custom colors colormaps, tested with grid colormaps.

Issue is that the colormap doesnt choose the right color that it should, even worse is that this changes every time i restarted the game.

Test1: try1 Test2: try2

SeaOfPixels commented 3 weeks ago

Can confirm, colormaps are currently incorrect. 2024-06-08_14 39 31

SnobbyBlobby commented 3 weeks ago

Can also confirm : t1 t2

Also randomizes everytime I close the game.

Pineapple71717 commented 2 weeks ago

While it does randomize the colormaps, atleast on my end they dont seem to change every time I re-launch the game 2024-06-15_18 44 53 2024-06-15_18 40 55 2024-06-15_18 37 44 2024-06-15_18 33 23 2024-06-15_18 32 05 2024-06-15_18 31 20 jlkhjghsdgb

SeaOfPixels commented 2 weeks ago

It's not that the colormaps are randomizing, it's that the gridmap IDs are incorrect. This happens all the time during OptiFine development when updating to new whole number versions.

Emfire12345 commented 2 weeks ago

It's not that the colormaps are randomizing, it's that the gridmap IDs are incorrect. This happens all the time during OptiFine development when updating to new whole number versions.

In the last few version that happend because they added new biomes which offset the IDs, 1.21 didnt add a single new biome and the IDs are not shifted, they are shuffled all over the place, if the plains biome gets the wrong color you know something is messed up badly.

SeaOfPixels commented 2 weeks ago

It's not that the colormaps are randomizing, it's that the gridmap IDs are incorrect. This happens all the time during OptiFine development when updating to new whole number versions.

In the last few version that happend because they added new biomes which offset the IDs, 1.21 didnt add a single new biome and the IDs are not shifted, they are shuffled all over the place, if the plains biome gets the wrong color you know something is messed up badly.

No, this has happened multiple times before in update transitions that had no new biomes or changes to the IDs.

SyndiShanX commented 2 days ago

It would be nice if we could specify the columns using the Biome Namespace ID in the .properties file

Emfire12345 commented 1 day ago

It would be nice if we could specify the columns using the Biome Namespace ID in the .properties file

I wish we could have 256x256 colormaps for each biome, were 1 pixel = 1 block, similar to how colormaps were applied pre beta 1.8, then you could literally paint the landscape

SeaOfPixels commented 13 hours ago

I think the current method would be fine if gridmaps didn't keep extending past the farthest vanilla ID (End Barrens) into the unused IDs. This currently breaks grid colormap compatibility with mods that use unused biome IDs for their modded biomes. The gridmaps should only apply the columns that are actually used by vanilla (currently that's ID 0 to 63, so ID 64 onward would ignore gridmaps).

SyndiShanX commented 12 hours ago

But mod compatibility is something we want

SeaOfPixels commented 5 hours ago

The current method breaks when multiple sources (datapacks/mods) use the same biome IDs anyways, which is very likely to happen.

SyndiShanX commented 5 hours ago

Namespace IDs would fix that

SeaOfPixels commented 5 hours ago

Ye just doing everything in a file would be best, however I think that's way less likely to happen since it'd be way more work for SP, so I tried suggesting something that I thought would be less taxing.