search

sp614x / optifine

1.79k stars 418 forks source link

[1.21pre5 Crash] Enchantment-based CIT (like enchanted books) causes a crash #7709

Closed SeaOfPixels closed 1 week ago

SeaOfPixels commented 2 weeks ago

Description of Issue

Attempting to enable my resource pack New Default+ (https://minecraft.curseforge.com/projects/newdefaultplus) in OptiFine 1.21_HD_U_J1_pre5 results in a crash, even on the main menu. It is seemingly caused by CIT that uses the enchantments= parameter, as removing any CIT that uses this prevents the crash. Crash report: Crash Report.txt

Steps to Reproduce

  1. Open Minecraft
  2. Enable resource pack in the resource packs menu that contains enchantment-based CIT

OptiFine Version

OptiFine 1.21_HD_U_J1_pre1, OptiFine 1.21_HD_U_J1_pre2, OptiFine 1.21_HD_U_J1_pre3, OptiFine 1.21_HD_U_J1_pre4, OptiFine 1.21_HD_U_J1_pre5

REV3RSE-408 commented 2 weeks ago

Got the same issue with my resource pack. Maybe there is something wrong with emissive textures on blocks. As soon as I removed the _e texture, the game did not crash anymore. I tested around ten different blocks, and it happened on every single one of them. As soon as there is an emissive texture involved, the game just crashes.

SeaOfPixels commented 2 weeks ago

Mine crashed before I could even get into a world though, on the main menu, where no emissives were loaded.

AliolyMader commented 2 weeks ago

Same Issue, still not work in optifine 1.21 pre2

kpikes commented 2 weeks ago

Problem persists in Pre2, praying this gets fixed asap

Romanlab1 commented 2 weeks ago

Same issue here, tested with different texture packs, crashes everytime, I tried with New Default + and Great Shrimpsby's texture pack

SeaOfPixels commented 1 week ago

Fixed in pre6, new bug created: https://github.com/sp614x/optifine/issues/7734