search

sp614x / optifine

1.81k stars 418 forks source link

[1.12] Sky color bug when hovering items in creative menu #7769

Open boredhuman opened 3 weeks ago

boredhuman commented 3 weeks ago

Description of Issue

When hovering a item in the creative menu, the sky becomes darkened. This happens because the tooltip enables lighting, the lighting is then disabled by either the toast gui or the framebuffer copy from mc to default. When f1 is enabled hide gui is true and so the toast gui lighting disable logic is skipped and when fast render is enabled the copying of framebuffers is skipped and so the lighting disable from there is also skipped. Ideal fix would be to disable lighting regardless of fast render after frame buffer copy

Steps to Reproduce

  1. Enable fast render
  2. Enable sky
  3. go into f1
  4. open creative menu
  5. hover over item

OptiFine Version

1.12.2 G5

Installation Method

Standalone

Log Files/Crash Reports

N/A

F3 Debug Screenshot

Not needed. My machine does support framebuffers

Prior Testing

Won't happen in vanilla unless, the users graphics cards doesn't support frame buffers

Additional Information

(dark sky aka lighting still enabled during sky rendering) image (normal sky aka lighting disabled due to not hovering over any items in the creative menu) image

boredhuman commented 3 weeks ago

Also anti aliasing disables the framebuffer copy, just like fast render