search

spaam / svtplay-dl

Small command-line program to download videos from some streaming sites.
https://svtplay-dl.se
MIT License
714 stars 118 forks source link

svtplay-dl 4.97 does not work on Windows 7 because of cryptograhy v43. time to drop support win7? #1634

Open spaam opened 1 month ago

spaam commented 1 month ago

For some reason cryptography doesn't work on windows 7 anymore after their v43 version.

ImportError: DLL load failed while importing _rust: The specified procedure could not be found.

Skarmklipp

how to deal with this? i dont know. this only affecting windows 7 ( and maybe win 8 ). it works fine on win11. 1) using fixed version of cryptography for windows? that feels like a mess going to happen sooner or later. i dont like the idea to have a fixed version of a specific library that all platforms use. 2) drop support for win7? i have no idea how many people use windows 7 and svtplay-dl. microsoft support ended 4.5 years ago. I can't test stuff since i dont have access to a windows 7 system. 🤔

Sopor commented 1 month ago

Add a message if the user try to run it on lower Windows than 10.

This application only support Windows 10 and higher ...

posktomten commented 1 month ago

Probably not many people use Windows 7. But it works with Python 3.8 https://bin.ceicer.com/svtplay-dl/Windows/

spaam commented 1 month ago

yeah python version is not the issue. the issue is cryptography v43 dropped their support for windows 7. when we load the crypto stuff it just crashes.

posktomten commented 1 month ago

Hmm. I have Windows 7 64-bit as a virtual computer in Virtual Box and it actually works.

spaam commented 1 month ago

you are leaving out a bunch of info in your comment. what version are you using? version of cryptography? how did you install svtplay-dl? are you sure you are running windows 7?

SweDennis commented 1 month ago

Didn't see that one coming ... That today was the day that I would re-install win7 just to verify something ... (Living on the edge)

posktomten commented 1 month ago

Built with Windows 10 Pro 64-bit Version 22H2 OS build 19045.4717 svtplay-dl 4.97.1 python 3.8.5 cryptography 39.0.0

Windows 10 Pro 32-bit Version 22H2 build 19045.4651 svtplay-dl 4.97.1 python 3.8.5 cryptography 39.0.0

Running on Windows Professional 7 64-bit Service Pack 1

spaam commented 1 month ago

@posktomten you are using an old version of cryptography. That is fine. We talking about version 43+. 42 and older is fine.

posktomten commented 1 month ago

Yes, I understand this. "pip" thought cryptography 39.0.0 was the latest version. On Windows 10, python 3.8.5.