spaar / besiege-modloader

spaar's Mod Loader for Besiege - Deprecated
Other
57 stars 14 forks source link

ModLoader.AddPiece not being set #25

Closed spaar closed 9 years ago

spaar commented 9 years ago

After moving setting the AddPiece reference from the object explorer to ModLoader, it is never being set at all. Unfortunately the game object the mod loader is attached to is destroyed when exiting the main menu and the mod loader with it, ensuring that the search for AddPiece never succeeds as that is only created after that. There would be multiple ways to fix this:

There are probably other ways as well, what do you think would be the best way to handle this?

L3tum commented 9 years ago

I would be for the 3rd idea, because 1) needs a new class and more to load, 2) it probably difficult to load and could lead to bugs. I haven't followed the commits for some time, so why did you move it into the mod loader?

spaar commented 9 years ago

3rd sounds good. That was some time ago actually, when the object explorer was completely excluded from non-developer builds. That's why it can't be set there anymore.

L3tum commented 9 years ago

Oh yeah, sorry.... What about making an own AddPiece class?

spaar commented 9 years ago

I think that's kind of overkill

L3tum commented 9 years ago

^^ Ok

spaar commented 9 years ago

Alright, fixed.