search

spaar / besiege-modloader

spaar's Mod Loader for Besiege - Deprecated
Other
57 stars 14 forks source link

Fixed version downloading from GitHub #71

Closed shuni64 closed 6 years ago

shuni64 commented 6 years ago

GitHub recently dropped support for TLS 1 and it appears that the default TLS version of WebClient is TLS 1.1. This commit allows the installer to use TLS 1.2 or SSL instead of older versions.

spaar commented 6 years ago

Thank you very much! This is a great catch, I don't think I would have fixed this anytime soon and I'm sure many people are very happy the installer works again.

One note: I added another commit to remove the SSLv3 option again, as (although this is not exactly obvious) SSLv3 is actually older than even TLS1.0, so I'm just assuming that GitHub doesn't support it anymore either, with TLS1.2 being sufficient.