space-concordia-robotics / robotics-prototype

Teleoperated Mars rover with autonomous capabilities intended for robotics competitions.
https://spaceconcordia.github.io/robotics.html
25 stars 18 forks source link

Decouple PidController.h from the Arm class into a generic PIDController class #463

Closed MartensCedric closed 1 year ago

MartensCedric commented 4 years ago

The current PidController.h found in robot/rover/Arm/ is coupled to the Arm subsystem (prints saying stuff about the Arm, a variable about joint limits). This issue is about making a generic PidController class. A suggestion (which you don't need to follow) is to have a subclass ArmPidController that inherits the additional behaviors. Ideally, it should also work to replace the one in MobilePlatform