search

space-concordia-robotics / robotics-prototype

Teleoperated Mars rover with autonomous capabilities intended for robotics competitions.
https://spaceconcordia.github.io/robotics.html
25 stars 18 forks source link

Power report 568 #569

Closed vexandmore closed 2 years ago

vexandmore commented 2 years ago

Assignee Section

Description

The power report node records power consumption starting when a start command is sent to it, and when stopped it saves it to a file. The latest power report is also retrievable from a service the node provides.

Steps for Testing

  1. Ensure the rover is on this branch and started up (or use the local_rover.launch file in robot/util/rosRoverStart)
  2. Run this command: rostopic pub /power_report_command std_msgs/String "data: 'start'". This will start the recording.
  3. Wait some time
  4. Run this command: rostopic pub /power_report_command std_msgs/String "data: 'stop'". This will stop the recording.
  5. Check in ~/Power_Reports for a power report.
  6. Run this command: rosservice call /power_report_provider 0 to see the latest report at any time

closes #568

The approval from all software team leads is necessary before merging.

Reviewer Section

Aside from local testing and the General Integration Test it is implied that static analysis should be included in the verification process.

For Pull Requests that do not include code changes, it is not required to perform the tests above.

RealWilliamWells commented 2 years ago

Looks good at a glance. I would just check with physical measurement to make sure that all the math checks out before relying on it.

We did do this for the OBC and it was spot on. Given that it's going through the same code for all of the other calculations, I believe it should be fine. Further testing will be done anyways this weekend as Joshua wants to measure current draw of the full system and we will be taking the rover outside a bit for filming

VimFreeman commented 2 years ago

Looks good at a glance. I would just check with physical measurement to make sure that all the math checks out before relying on it.

We did do this for the OBC and it was spot on. Given that it's going through the same code for all of the other calculations, I believe it should be fine. Further testing will be done anyways this weekend as Joshua wants to measure current draw of the full system and we will be taking the rover outside a bit for filming

Ok perfect