space-concordia-robotics / robotics-rover

This is the actual code running on the rover.
1 stars 0 forks source link

Add wrong value detection for movement in ucontroller manager before sending the commands. #14

Closed Doomfest closed 9 years ago

Doomfest commented 9 years ago

Need to detech if values received to the ucontr manager are valid before sending them to the ucontroller for movement.

Doomfest commented 9 years ago

I added code which validates the values before sending them to the micro. @psyomn i was testing your client and the server was receiving everything . We need to check which numbers the client sends to the server. It seems like it sends all numbers and doesnt care about forward, reverse, turn left , right and stop movements.

psyomn commented 9 years ago

I'm not sure I understand what you mean. The server understands what command is sent - that's why there are the constants, then the commands (patterns) which are executed, and finally fire the hooks if any exist.

Doomfest commented 9 years ago

The validation code happens within the ucontroller manager.