space-nuko / ComfyBox

Customizable Stable Diffusion frontend for ComfyUI
GNU General Public License v3.0
586 stars 45 forks source link

SaveImage not properly handling save file formatting strings #144

Open halr9000 opened 11 months ago

halr9000 commented 11 months ago

I'm trying to use a better filename convention than just "ComfyUI", so I went to try a string which works outside of comfybox as per the comfyui docs, such as: %date:yyyy-MM-dd%/%Generate Image.seed%-

Instead of a filename such as: 2024-08-15/234r234234234-00001.png, it throws an exception. Here's the console:

!!! Exception during processing !!!
Traceback (most recent call last):
  File "D:\hal\stable-diffusion\ComfyUI\folder_paths.py", line 219, in get_save_image_path
FileNotFoundError: [WinError 3] The system cannot find the path specified: 'D:\\hal\\stable-diffusion\\ComfyUI\\output\\%date:yyyy-MM-dd%'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\hal\stable-diffusion\ComfyUI\execution.py", line 151, in recursive_execute
    output_data, output_ui = get_output_data(obj, input_data_all)
  File "D:\hal\stable-diffusion\ComfyUI\execution.py", line 81, in get_output_data
    return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
  File "D:\hal\stable-diffusion\ComfyUI\execution.py", line 74, in map_node_over_list
    results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
  File "D:\hal\stable-diffusion\ComfyUI\nodes.py", line 1265, in save_images
    full_output_folder, filename, counter, subfolder, filename_prefix = folder_paths.get_save_image_path(filename_prefix, self.output_dir, images[0].shape[1], images[0].shape[0])
  File "D:\hal\stable-diffusion\ComfyUI\folder_paths.py", line 223, in get_save_image_path
  File "C:\Users\hal\AppData\Local\Programs\Python\Python310\lib\os.py", line 225, in makedirs
    mkdir(name, mode)
NotADirectoryError: [WinError 267] The directory name is invalid: 'D:\\hal\\stable-diffusion\\ComfyUI\\output\\%date:yyyy-MM-dd%'