search

space-nuko / ComfyBox

Customizable Stable Diffusion frontend for ComfyUI
GNU General Public License v3.0
615 stars 48 forks source link

Dummy-Downed ComfyBox #156

Open ChessScholar opened 10 months ago

ChessScholar commented 10 months ago

Update 12/11/23

Thank you again @TsengSR for the comments. I took the time to figure out how to get the fork done properly (was mostly user-error 😅).

https://github.com/ChessScholar/ComfyBox-ReOpened-Forked-

This will now properly show all of the changes. "Assets" was completely unnecessary and removed. I left them in archive of the original so you can still access them to see what they were just in case anyone is curious.

Sidenote: I also made my activity on my profile public. I didn't realize that was so important for integrity, though it makes sense.

This is to (hopefully) help those who have had issues running on Windows.

https://github.com/ChessScholar/ComfyBox_ReOpened.git

Edit 12/10/23 This repository is not "forked" at the moment. I had cloned the original, modified it, then uploaded as a new repo on my profile. I will learn how to properly "fork" their repo so that the changes made are reflected. Thank you for your patience.

TsengSR commented 10 months ago

Looks fishy to me, it's not shown as forked on the GitHub page, making it very hard to find and validate the exact changes since the laste state of this repository and also has assets published into it. Its not very confident to trust in a persons GitHub Repository who doesn't know how to properly fork or exclude asserts.

I don't think you have what it needs it to continue this project and no activity on your profile or your previous works.

ChessScholar commented 10 months ago

Thank you for your feedback, I 100% understand and agree as I was making it. I'm still getting used to GitHub (particularly how "forks" work) and properly getting a fork going was giving me strange problems didn't understand.

If you're not comfortable with it right now, please don't use it. I'll let everyone know when I am able to fork it properly such that the changes are reflected.

ChessScholar commented 10 months ago

Updated! :D

ameen-roayan commented 9 months ago

Hi @ChessScholar i am getting this error

127.0.0.1 - - [14/Dec/2023 09:56:59] "GET / HTTP/1.1" 304 -

http://localhost:8000/ is an empty blank white page as well

halr9000 commented 9 months ago

Thank you for your feedback, I 100% understand and agree as I was making it. I'm still getting used to GitHub (particularly how "forks" work) and properly getting a fork going was giving me strange problems didn't understand.

If you're not comfortable with it right now, please don't use it. I'll let everyone know when I am able to fork it properly such that the changes are reflected.

for the record, github is confusing as hell, man! Way too much to learn for the "simple" use cases. There are memes https://xkcd.com/1597/