search

space-nuko / ComfyBox

Customizable Stable Diffusion frontend for ComfyUI
GNU General Public License v3.0
607 stars 49 forks source link

ctx.roundRect is not a function in firefox #92

Closed CapsAdmin closed 1 year ago

CapsAdmin commented 1 year ago 
TypeError: ctx.roundRect is not a function

drawNodeShape@http://localhost:3000/litegraph/packages/core/src/LGraphCanvas_Rendering.ts:956:13
drawNodeShape@http://localhost:3000/litegraph/packages/core/src/LGraphCanvas.ts:1611:52
drawNodeShape@http://localhost:3000/src/lib/ComfyGraphCanvas.ts:64:11
drawNode@http://localhost:3000/litegraph/packages/core/src/LGraphCanvas_Rendering.ts:630:10
drawNode@http://localhost:3000/litegraph/packages/core/src/LGraphCanvas.ts:1605:47
drawNode@http://localhost:3000/src/lib/ComfyGraphCanvas.ts:224:23
drawFrontCanvas@http://localhost:3000/litegraph/packages/core/src/LGraphCanvas_Rendering.ts:116:14
drawFrontCanvas@http://localhost:3000/litegraph/packages/core/src/LGraphCanvas.ts:1584:54
draw@http://localhost:3000/litegraph/packages/core/src/LGraphCanvas_Rendering.ts:64:12
draw@http://localhost:3000/litegraph/packages/core/src/LGraphCanvas.ts:1581:43
canvasHandler@http://localhost:3000/src/lib/stores/workflowState.ts:58:40
emit@http://localhost:3000/node_modules/.vite/deps/events.js?v=9bce1bc5:105:21
onAfterExecute@http://localhost:3000/src/lib/ComfyGraph.ts:37:19
runStep@http://localhost:3000/litegraph/packages/core/src/LGraph.ts:242:16
on_frame@http://localhost:3000/litegraph/packages/core/src/LGraph.ts:165:14
start@http://localhost:3000/litegraph/packages/core/src/LGraph.ts:170:7
start@http://localhost:3000/src/lib/stores/workflowState.ts:71:18
setActiveWorkflow@http://localhost:3000/src/lib/stores/workflowState.ts:234:12
addWorkflow@http://localhost:3000/src/lib/stores/workflowState.ts:193:22
openWorkflow@http://localhost:3000/src/lib/stores/workflowState.ts:185:14
openWorkflow@http://localhost:3000/src/lib/components/ComfyApp.ts:532:32
initDefaultWorkflow@http://localhost:3000/src/lib/components/ComfyApp.ts:631:16

works in chrome though

space-nuko commented 1 year ago

Which firefox? My version is Nightly 112.0b8 and it works

CapsAdmin commented 1 year ago

107.0.1 (64-bit), so to my surprise a bit old, I thought it was a little more recent. (running nixos)

I can try upgrading or using nightly.

According to caniuse it's available in 112 which was released this month, https://caniuse.com/mdn-api_canvasrenderingcontext2d_roundrect

space-nuko commented 1 year ago

I think it's supported by all modern browsers (also same function is used by ComfyUI) so I'll close