search

space-ros / docker

Docker images to facilitate Docker-based development.
15 stars 12 forks source link

Incorrect use of `source` in docker images #121

Open Bckempa opened 5 months ago

Bckempa commented 5 months ago

Discussed in https://github.com/space-ros/docker/discussions/106

Several Dockerfiles source colcon workspace over/underlays in ways that don't impact the environment of any commands, these are no-ops at best and potentially causing undesired behavior.

https://github.com/space-ros/docker/blob/76cd412a7379dd5a5ec338b7b75659afbbf0c9a1/space_robots/Dockerfile#L81-L82

ivanperez-keera commented 5 months ago

@Bckempa in case you don't know, you have an option to convert a discussion into an issue. That way, you don't need to link to the prior discussion and all necessary context is included.

Bckempa commented 5 months ago

@Bckempa in case you don't know, you have an option to convert a discussion into an issue. That way, you don't need to link to the prior discussion and all necessary context is included.

That's how I opened this issue, did you expect it to close the corresponding discussion like it does when you convert the other direction?

ivanperez-keera commented 5 months ago

My bad. I thought it would "convert" like it does in the opposite direction, but it creates a separate issue and leaves the discussion open. Github is weird.