search

space-ros / docker

Docker images to facilitate Docker-based development.
15 stars 12 forks source link

Make excluded pkgs consistent across rosdep and vcs (#88). #122

Closed xfiderek closed 5 months ago

xfiderek commented 5 months ago

Summary

Addresses https://github.com/space-ros/docker/issues/88. Now 'excluded-pkgs.txt' can be used both to create list of repos (vcs), as well as to install necessary system dependencies (rosdep).

Dependencies

https://github.com/ament/ament_ikos/pull/3 https://github.com/space-ros/space-ros/pull/131

Final test will be conducted after these PRs are merged, but any preliminary reviews are welcomed :).

Tests

I tested output of both versions with rosdep install --simulate and there is 100% match.

Open points

Prior to fix there was a console_bridge package in skip-keys. There is no such package in rosdep index, so it had no effect. However I saw that libconsole-bridge-dev gets installed, which is exactly the package that was intended to be excluded. Do we know what was the intention behind excluding this package?

xfiderek commented 5 months ago

As discussed in https://github.com/space-ros/space-ros/discussions/126#discussioncomment-8247215, we will hard-code ikos in --skip-keys for now