search

space-ros / docker

Docker images to facilitate Docker-based development.
20 stars 30 forks source link

Refactor docker build of moveit2 to use build.sh #66

Open mkhansenbot opened 1 year ago

mkhansenbot commented 1 year ago

Since we're providing a build.sh script for users to build the containers, we should use those in the build flow to ensure that the users build script is always working

This is done in #65 for the space_robots build, and needs to be done for the moveit2 build.

Bckempa commented 9 months ago

Preliminarily nominating this for next release as part of a planned revision of the existing docker files. If it doesn't make it as part of that clean-up effort it can be descoped.

EzraBrooks commented 8 months ago

I've just realized that if we do this, we'll either lose the automatic GitHub Actions caching stuff for the Docker builds or have to create a custom implementation of it.. this might not be a good idea. Perhaps it's better to keep the build.sh scripts thin wrappers around docker build.

mkhansenbot commented 8 months ago

I'm open to any other way of testing the build.sh scripts. However, I'm not sure what we lose. Did you see the implementation in #65?

EzraBrooks commented 8 months ago

I didn't realize at the time, but I believe that change in #65 also lost us some caching in CI.

EzraBrooks commented 8 months ago

We should consider eliminating build.sh in favor of more cleanly encapsulated Dockerfiles and Earthlyfiles so you just run docker build or earthly build

Bckempa commented 7 months ago

Yet another issue partially impacted by the resolution of https://github.com/space-ros/space-ros/discussions/114

mkhansenbot commented 7 months ago

Added to next milestone (proposed) humble-2024.04.0