search

space-ros / docker

Docker images to facilitate Docker-based development.
20 stars 30 forks source link

Fix hidden container dependencies of `space_robots` #92

Open Bckempa opened 10 months ago

Bckempa commented 10 months ago

The space-robots container currently assumes both the space-ros and Space ROS moveit2 containers are locally built, and sources their underlays in a sneaky manner that will not pay nice with cache and provides a potential foot-gun.

EzraBrooks commented 9 months ago

split into https://github.com/space-ros/docker/issues/86

EzraBrooks commented 9 months ago

Top-level build script should be changed to just invoke all the right builds in order

Bckempa commented 8 months ago

As @EzraBrooks noticed:

whoa.. also why do containers like space-ros/moveit2 run vcs import on the .repos file from magically-defined ${SPACEROS_DIR}

xfiderek commented 4 months ago

As @EzraBrooks noticed:

whoa.. also why do containers like space-ros/moveit2 run vcs import on the .repos file from magically-defined ${SPACEROS_DIR}

This variable is defined in main spaceros Earthfile: https://github.com/space-ros/docker/blob/fd08bf95d9047a5641b17f53c91b9247ab7a964b/spaceros/Earthfile#L75